diff options
| author | Stanislav Laznicka <slaznick@redhat.com> | 2016-02-02 12:57:11 +0100 |
|---|---|---|
| committer | Jan Cholasta <jcholast@redhat.com> | 2016-02-24 09:21:30 +0100 |
| commit | d7efd8a33ab14a561d3af445e62bceb6f2f13fd1 (patch) | |
| tree | 2f03d17484383bc4114fff16cc9a5f56883e6752 /ipalib/plugins | |
| parent | 9757384c7c6337138b6e096d3bb926cdb3012ff6 (diff) | |
Fixes minor issues
Fixes issues discovered by Coverity
plugins/baseldap.py: possible undefined value in return
certmonger.py: possible dereference of None value
i18n.py: fixed always True bug (+ cosmetic change)
https://fedorahosted.org/freeipa/ticket/5661
Reviewed-By: Jan Cholasta <jcholast@redhat.com>
Reviewed-By: Martin Basti <mbasti@redhat.com>
Diffstat (limited to 'ipalib/plugins')
| -rw-r--r-- | ipalib/plugins/baseldap.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ipalib/plugins/baseldap.py b/ipalib/plugins/baseldap.py index 03a255ca1..ffc0008a6 100644 --- a/ipalib/plugins/baseldap.py +++ b/ipalib/plugins/baseldap.py @@ -451,12 +451,12 @@ def remove_external_post_callback(ldap, dn, entry_attrs, failed, completed, # Run through the failures and gracefully remove any member defined # as an external member. + completed_external = 0 if memberattr in failed and membertype in failed[memberattr]: entry_attrs_ = ldap.get_entry(dn, [externalattr]) dn = entry_attrs_.dn external_entries = entry_attrs_.get(externalattr, []) failed_entries = [] - completed_external = 0 for entry in failed[memberattr][membertype]: membername = entry[0].lower() |