diff options
author | David Kupka <dkupka@redhat.com> | 2016-08-11 14:30:00 +0200 |
---|---|---|
committer | Jan Cholasta <jcholast@redhat.com> | 2016-08-17 14:16:04 +0200 |
commit | 1b79ac67d709bbb9e665f0e741af89828281477d (patch) | |
tree | 47d78b7e7ec92bd5fb802096701704e2fd307c63 /ipaclient | |
parent | 87a6f746bcaad4d398227641f2c07c4f67235b56 (diff) | |
download | freeipa-1b79ac67d709bbb9e665f0e741af89828281477d.tar.gz freeipa-1b79ac67d709bbb9e665f0e741af89828281477d.tar.xz freeipa-1b79ac67d709bbb9e665f0e741af89828281477d.zip |
client: Do not create instance just to check isinstance
Checking that classes are idenical gives the same result and
avoids unnecessary instantiation.
https://fedorahosted.org/freeipa/ticket/6048
Reviewed-By: Jan Cholasta <jcholast@redhat.com>
Diffstat (limited to 'ipaclient')
-rw-r--r-- | ipaclient/plugins/automount.py | 4 | ||||
-rw-r--r-- | ipaclient/plugins/otptoken_yubikey.py | 3 | ||||
-rw-r--r-- | ipaclient/plugins/vault.py | 16 |
3 files changed, 11 insertions, 12 deletions
diff --git a/ipaclient/plugins/automount.py b/ipaclient/plugins/automount.py index 925b635ff..3742705fa 100644 --- a/ipaclient/plugins/automount.py +++ b/ipaclient/plugins/automount.py @@ -55,8 +55,8 @@ class _fake_automountlocation_show(Method): class automountlocation_tofiles(MethodOverride): @classmethod def __NO_CLI_getter(cls): - return isinstance(api.Command.automountlocation_show, - _fake_automountlocation_show) + return (api.Command.get_plugin('automountlocation_show') is + _fake_automountlocation_show) NO_CLI = classproperty(__NO_CLI_getter) diff --git a/ipaclient/plugins/otptoken_yubikey.py b/ipaclient/plugins/otptoken_yubikey.py index 549376a0f..1075b6d83 100644 --- a/ipaclient/plugins/otptoken_yubikey.py +++ b/ipaclient/plugins/otptoken_yubikey.py @@ -77,8 +77,7 @@ class otptoken_add_yubikey(Command): @classmethod def __NO_CLI_getter(cls): - return isinstance(api.Command.otptoken_add, - _fake_otptoken_add) + return api.Command.get_plugin('otptoken_add') is _fake_otptoken_add NO_CLI = classproperty(__NO_CLI_getter) diff --git a/ipaclient/plugins/vault.py b/ipaclient/plugins/vault.py index c0ded21d5..08bbeb50f 100644 --- a/ipaclient/plugins/vault.py +++ b/ipaclient/plugins/vault.py @@ -205,8 +205,8 @@ class vault_add(Local): @classmethod def __NO_CLI_getter(cls): - return isinstance(api.Command.vault_add_internal, - _fake_vault_add_internal) + return (api.Command.get_plugin('vault_add_internal') is + _fake_vault_add_internal) NO_CLI = classproperty(__NO_CLI_getter) @@ -411,8 +411,8 @@ class vault_mod(Local): @classmethod def __NO_CLI_getter(cls): - return isinstance(api.Command.vault_mod_internal, - _fake_vault_mod_internal) + return (api.Command.get_plugin('vault_mod_internal') is + _fake_vault_mod_internal) NO_CLI = classproperty(__NO_CLI_getter) @@ -598,8 +598,8 @@ class vault_archive(Local): @classmethod def __NO_CLI_getter(cls): - return isinstance(api.Command.vault_archive_internal, - _fake_vault_archive_internal) + return (api.Command.get_plugin('vault_archive_internal') is + _fake_vault_archive_internal) NO_CLI = classproperty(__NO_CLI_getter) @@ -855,8 +855,8 @@ class vault_retrieve(Local): @classmethod def __NO_CLI_getter(cls): - return isinstance(api.Command.vault_retrieve_internal, - _fake_vault_retrieve_internal) + return (api.Command.get_plugin('vault_retrieve_internal') is + _fake_vault_retrieve_internal) NO_CLI = classproperty(__NO_CLI_getter) |