summaryrefslogtreecommitdiffstats
path: root/install/ui
diff options
context:
space:
mode:
authorPavel Vomacka <pvomacka@redhat.com>2016-07-25 18:25:36 +0200
committerPetr Vobornik <pvoborni@redhat.com>2016-11-10 18:58:38 +0100
commitcad9f9b682d9bcc33fdfb1112e4cfb1a2c66a498 (patch)
treef30d519cf2af9a0800837fa5cefa231fd41d7cca /install/ui
parentd94a2aa185defba38f2bbe2c5ee28f9b9defc0f2 (diff)
downloadfreeipa-cad9f9b682d9bcc33fdfb1112e4cfb1a2c66a498.tar.gz
freeipa-cad9f9b682d9bcc33fdfb1112e4cfb1a2c66a498.tar.xz
freeipa-cad9f9b682d9bcc33fdfb1112e4cfb1a2c66a498.zip
Coverity - null pointer dereference
The 'obj' variable could be null, so there could be error when it is used. A new check that 'obj' is not false is added. Reviewed-By: Petr Vobornik <pvoborni@redhat.com>
Diffstat (limited to 'install/ui')
-rw-r--r--install/ui/src/freeipa/widgets/browser_widgets.js6
1 files changed, 3 insertions, 3 deletions
diff --git a/install/ui/src/freeipa/widgets/browser_widgets.js b/install/ui/src/freeipa/widgets/browser_widgets.js
index 57ad2bd98..91bb850a6 100644
--- a/install/ui/src/freeipa/widgets/browser_widgets.js
+++ b/install/ui/src/freeipa/widgets/browser_widgets.js
@@ -427,11 +427,11 @@ widgets.browser_widgets.CommandDetailWidget = declare([base], {
if (i>0) {
out_params_cnt.append(', ');
}
- if (!param) {
- out_params_cnt.append(param_name);
- } else {
+ if (param && obj) {
var link = this.render_param_link(obj.name, param_name);
out_params_cnt.append(link);
+ } else {
+ out_params_cnt.append(param_name);
}
}
out_params_cnt.appendTo(this.el);