summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMartin Basti <mbasti@redhat.com>2015-12-16 23:26:29 +0100
committerJan Cholasta <jcholast@redhat.com>2015-12-23 07:59:22 +0100
commitfb3eab7ec74ccae7b45a608fe40a6ab4d4093488 (patch)
treea01e3c6d8a05cda3e1812e3c51f06f51dcd0a91e
parent837e8f8160cceef71f206064517704e1cc577637 (diff)
Enable pylint lost exception check
Commit enables check and also fixes: ipaserver/dcerpc.py:718: [W0150(lost-exception), DomainValidator.__search_in_dc] return statement in finally block may swallow exception) Reviewed-By: Jan Cholasta <jcholast@redhat.com>
-rw-r--r--ipaserver/dcerpc.py4
-rwxr-xr-xmake-lint1
2 files changed, 2 insertions, 3 deletions
diff --git a/ipaserver/dcerpc.py b/ipaserver/dcerpc.py
index 32e1ab5a8..b206b7aba 100644
--- a/ipaserver/dcerpc.py
+++ b/ipaserver/dcerpc.py
@@ -714,8 +714,8 @@ class DomainValidator(object):
root_logger.debug(msg)
else:
root_logger.warning(msg)
- finally:
- return entries
+
+ return entries
def __retrieve_trusted_domain_gc_list(self, domain):
"""
diff --git a/make-lint b/make-lint
index 4142821f6..f8cf3214a 100755
--- a/make-lint
+++ b/make-lint
@@ -264,7 +264,6 @@ def main():
linter.set_option('disable', 'global-statement')
linter.set_option('disable', 'global-variable-not-assigned')
linter.set_option('disable', 'global-variable-undefined')
- linter.set_option('disable', 'lost-exception')
linter.set_option('disable', 'no-init')
linter.set_option('disable', 'pointless-except')
linter.set_option('disable', 'pointless-statement')