summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLenka Doudova <ldoudova@redhat.com>2016-08-17 16:37:29 +0200
committerMartin Basti <mbasti@redhat.com>2016-08-17 17:41:08 +0200
commit44a2bdd8ead48b33b23bfb1e1f71027e5cfc5f04 (patch)
tree52cf51d8b57f9d7ebefb92f39d5051d9ebbd2469
parent380ffcc052c561084d0ef3f65f379bc762d9a326 (diff)
downloadfreeipa-44a2bdd8ead48b33b23bfb1e1f71027e5cfc5f04.tar.gz
freeipa-44a2bdd8ead48b33b23bfb1e1f71027e5cfc5f04.tar.xz
freeipa-44a2bdd8ead48b33b23bfb1e1f71027e5cfc5f04.zip
Tests: Fix failing tests in test_ipalib/test_frontend
Some tests in ipatests/test_ipalib/test_frontend.py are failing due to changes related to thin client implementation. Providing fix for: ipa.test_ipalib.test_frontend.test_Attribute.test_init ipa.test_ipalib.test_frontend.test_LocalOrRemote.test_run https://fedorahosted.org/freeipa/ticket/6188 Reviewed-By: Milan Kubik <mkubik@redhat.com>
-rw-r--r--ipalib/frontend.py2
-rw-r--r--ipatests/test_ipalib/test_frontend.py12
2 files changed, 7 insertions, 7 deletions
diff --git a/ipalib/frontend.py b/ipalib/frontend.py
index 455b222d4..554d899d9 100644
--- a/ipalib/frontend.py
+++ b/ipalib/frontend.py
@@ -1181,7 +1181,7 @@ class LocalOrRemote(Command):
When running in a server context, this command is always executed
locally and the value of ``options['server']`` is ignored.
"""
- if options['server'] and not self.env.in_server:
+ if options.get('server', False) and not self.env.in_server:
return self.forward(*args, **options)
return self.execute(*args, **options)
diff --git a/ipatests/test_ipalib/test_frontend.py b/ipatests/test_ipalib/test_frontend.py
index c3dd9104c..892328a37 100644
--- a/ipatests/test_ipalib/test_frontend.py
+++ b/ipatests/test_ipalib/test_frontend.py
@@ -862,13 +862,13 @@ class test_LocalOrRemote(ClassChecker):
api.finalize()
cmd = api.Command.example
assert cmd(version=u'2.47') == dict(
- result=('execute', (None,), dict(version=u'2.47', server=False))
+ result=('execute', (), dict(version=u'2.47'))
)
assert cmd(u'var', version=u'2.47') == dict(
- result=('execute', (u'var',), dict(version=u'2.47', server=False))
+ result=('execute', (u'var',), dict(version=u'2.47'))
)
assert cmd(server=True, version=u'2.47') == dict(
- result=('forward', (None,), dict(version=u'2.47', server=True))
+ result=('forward', (), dict(version=u'2.47', server=True))
)
assert cmd(u'var', server=True, version=u'2.47') == dict(
result=('forward', (u'var',), dict(version=u'2.47', server=True))
@@ -880,13 +880,13 @@ class test_LocalOrRemote(ClassChecker):
api.finalize()
cmd = api.Command.example
assert cmd(version=u'2.47') == dict(
- result=('execute', (None,), dict(version=u'2.47', server=False))
+ result=('execute', (), dict(version=u'2.47', server=False))
)
assert cmd(u'var', version=u'2.47') == dict(
result=('execute', (u'var',), dict(version=u'2.47', server=False))
)
assert cmd(server=True, version=u'2.47') == dict(
- result=('execute', (None,), dict(version=u'2.47', server=True))
+ result=('execute', (), dict(version=u'2.47', server=True))
)
assert cmd(u'var', server=True, version=u'2.47') == dict(
result=('execute', (u'var',), dict(version=u'2.47', server=True))
@@ -1106,7 +1106,7 @@ class test_Attribute(ClassChecker):
"""
user_obj = 'The user frontend.Object instance'
class api(object):
- Object = dict(user=user_obj)
+ Object = {("user", "1"): user_obj}
@staticmethod
def is_production_mode():
return False