diff options
| author | Stef Walter <stefw@redhat.com> | 2014-01-10 11:50:43 +0100 |
|---|---|---|
| committer | Jakub Hrozek <jhrozek@redhat.com> | 2014-02-24 11:14:55 +0100 |
| commit | 3e7d7af1953410f3f009bf3b2e481a46fb80de83 (patch) | |
| tree | 669043107509b29393adc56b182b7c568bf26001 | |
| parent | fcd8093c58638dc7c4f9cddfc97f273b94ce2ead (diff) | |
| download | sssd-3e7d7af1953410f3f009bf3b2e481a46fb80de83.tar.gz sssd-3e7d7af1953410f3f009bf3b2e481a46fb80de83.tar.xz sssd-3e7d7af1953410f3f009bf3b2e481a46fb80de83.zip | |
nss: Stop using one DBus interface with totally different methods
This is an incorrect use of DBus, where we use a single interface
name with completely different sets of methods.
Easily fixed.
Once the vtable stuff is in use then this would be automatically
detected and fail to build.
Reviewed-by: Jakub Hrozek <jhrozek@redhat.com>
Reviewed-by: Sumit Bose <sbose@redhat.com>
Reviewed-by: Lukáš Slebodník <lslebodn@redhat.com>
Reviewed-by: Simo Sorce <simo@redhat.com>
| -rw-r--r-- | src/providers/data_provider.h | 1 | ||||
| -rw-r--r-- | src/providers/data_provider_be.c | 2 | ||||
| -rw-r--r-- | src/responder/nss/nsssrv.c | 2 |
3 files changed, 3 insertions, 2 deletions
diff --git a/src/providers/data_provider.h b/src/providers/data_provider.h index f88637c2d..c33445c9e 100644 --- a/src/providers/data_provider.h +++ b/src/providers/data_provider.h @@ -60,6 +60,7 @@ /* this is a reverse method sent from providers to * the nss responder to tell it to update the mmap * cache */ +#define DP_REV_INTERFACE "org.freedesktop.sssd.dataprovider_rev" #define DP_REV_METHOD_UPDATE_CACHE "updateCache" #define DP_REV_METHOD_INITGR_CHECK "initgrCheck" diff --git a/src/providers/data_provider_be.c b/src/providers/data_provider_be.c index bfb776cae..2e6422693 100644 --- a/src/providers/data_provider_be.c +++ b/src/providers/data_provider_be.c @@ -857,7 +857,7 @@ static void acctinfo_initgroups_callback(struct be_req *be_req, /* Set up null request */ msg = dbus_message_new_method_call(NULL, DP_PATH, - DP_INTERFACE, + DP_REV_INTERFACE, DP_REV_METHOD_INITGR_CHECK); if (!msg) { DEBUG(SSSDBG_CRIT_FAILURE, "Out of memory?!\n"); diff --git a/src/responder/nss/nsssrv.c b/src/responder/nss/nsssrv.c index 9d0c9969a..d258dfc71 100644 --- a/src/responder/nss/nsssrv.c +++ b/src/responder/nss/nsssrv.c @@ -379,7 +379,7 @@ static struct sbus_method nss_dp_methods[] = { }; struct sbus_interface nss_dp_interface = { - DP_INTERFACE, + DP_REV_INTERFACE, DP_PATH, SBUS_DEFAULT_VTABLE, nss_dp_methods, |