| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit fafb8ad2b81b9a46cf8259bedc1dca5023b06115.
This fix is not valid:
1. convert_string() is not only used for key strings but also for data.
2. Some databases use string_tdb_data() i.e. non-null-terminated strings
as keynames and others (like the one I was using), use
string_term_tdb_data(), i.e. zero-terminated key strings.
After discussion with Metze, the easiest (and proper way) to
handle this is to specify key names as "keyname\0" for databases
which use string_term_tdb_data().
Sorry for the noise...
Michael
(This used to be commit 17c012c4645f4e9542537c15f80d9b4e74304d11)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This prevented all commands operating on keys (all non-traverse commands)
in tdbtool to fail with a "fetch failed" or "delete failed" message.
It seems that it fixes bug #2344 ...
Apparently this bug was introduced with 94e53472666ed in 2005.
Either nobody is using tdbtool or else tdb_find() has become
more strict about the key legth in the meantime. :-)
Michael
(This used to be commit fafb8ad2b81b9a46cf8259bedc1dca5023b06115)
|
| |
|
|
| |
(This used to be commit 7077df3e2e3f171532f6a5ac87d45201736c9c11)
|
| |
|
|
|
|
|
|
| |
Add in the alarm fix to allow locks to exit on
alarm signal.
Sync up the changes in tools.
Jeremy.
(This used to be commit cb6c663fa8818f49cc36f196bb5f4dea47edd69e)
|
| |
|
|
|
|
| |
There are still a few tidyups of old FSF addresses to come (in both s3
and s4). More commits soon.
(This used to be commit fcf38a38ac691abd0fa51b89dc951a08e89fdafa)
|
| |
|
|
|
|
|
|
|
| |
should I merge this to SAMBA_3_0? as it's also totally
broken there, as the connection_struct definition is completely
different
metze
(This used to be commit 5677b01d1dc63276a36daac400d5b0d935034ce6)
|
| |
|
|
|
| |
metze
(This used to be commit f471e752161e392ef7324df30517af1818a27d1d)
|
| |
|
|
| |
(This used to be commit aca417c6b164b54334cc46e126dd362ddab509d3)
|
| |
|
|
|
| |
Andrew Bartlett
(This used to be commit d0ed7cd241e0e7889406f62fd620d8fe39d4498c)
|
| |
|
|
|
| |
Andrew Bartlett
(This used to be commit a6e0846d9b5f1adc2ff137247a5c3f32746e43b5)
|
| |
|
|
|
|
|
|
| |
This clearly links the log function with its private pointer, and
makes the argument list for tdb_open_ex a bit shorter.
Andrew Bartlett
(This used to be commit 5d5503e8d8a10ead3ef21a5ffda52cadb9a07727)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
as part of ldb.
This allows tdb failures to be passed all the way up to Samba's DEBUG
system, which allowed easier debugging.
Unfortunately I had to extend the tdb API, as the logging function
didn't have a context pointer.
I've worked over the 'debug levels' in TDB. Most of them were 0,
which didn't seem right, as some were trace-like messages. We didn't
see any of these previously, except when accessing TDB directly.
Andrew Bartlett
(This used to be commit 58898092c1ce043f6d698db5065f372b79109e22)
|
| |
|
|
|
|
|
|
|
| |
samba-technical posting for more details on the transactions design.
This also adds a number of command line arguments to tdbtorture,
making it more flexible, and fixes some lock deadlock conditions in
the tdbtorture code.
(This used to be commit 06bd8abba942ec9f1e23f5c5d546cbb71ca3a701)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
just involves splitting up the core tdb.c code into separate files on
logical boundaries, but there are some minor functional changes as well:
- move the 'struct tdb_context' into tdb_private.h, hiding it from
users. This was done to allow the structure to change without
breaking code that uses tdb.
- added accessor functions tdb_fd(), tdb_name(), and tdb_log_fn() to
access the elements of struct tdb_context that were used by
external code but are no longer visible
- simplied tdb_append() to use tdb_fetch()/tdb_store(), which is just
as good due to the way tdb locks work
- changed some of the types (such as tdb_off to tdb_off_t) to make
syntax highlighting work better
- removed the old optional spinlock code. It was a bad idea.
- fixed a bug in tdb_reopen_all() that caused tdbtorture to sometimes
fail or report nasty looking errors. This is the only real bug
fixed in this commit. Jeremy/Jerry, you might like to pickup this
change for Samba3, as that could definately affect smbd in
Samba3.
The aim of all of these changes is to make the tdb
transactions/journaling code I am working on easier to write. I
started to write it on top of the existing tdb.c code and it got very
messy. Splitting up the code makes it much easier to follow.
There are more cleanups we could do in tdb, such as using uint32_t
instead of u32 (suggested by metze). I'll leave those for another day.
(This used to be commit 4673cdd0d261614e707b72a7a348bb0e7dbb2482)
|
| |
|
|
| |
(This used to be commit 0333f417a86a54a328ca9bd908076f9fe8405dc7)
|
| |
|
|
|
| |
metze
(This used to be commit 4c1c9f59ccea8b6cd7edf3bad8acb9cd8c772670)
|
| |
|
|
|
| |
metze
(This used to be commit b5378803fdcb3b3afe7c2932a38828e83470f61a)
|
|
|
metze
(This used to be commit bacab322ce89979f0ad0811cd15b73d81eceb69d)
|
