summaryrefslogtreecommitdiffstats
path: root/libcli/security/object_tree.c
Commit message (Collapse)AuthorAgeFilesLines
* libcli-security: Add documentation for object_tree_modify_accessMatthieu Patou2013-01-211-2/+12
| | | | Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* libcli/security: remove useless if (root->num_of_children > 0) statementsAndrew Bartlett2013-01-211-8/+4
| | | | | | | | | | The for loop does this implicitly when comparing for (i = 0; i < root->num_of_children; i++) Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* libcli/security: add init_mask to existing children in insert_in_object_treeStefan Metzmacher2013-01-211-0/+1
| | | | | | Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* libcli/security: handle node initialisation in one spot in ↵Andrew Bartlett2013-01-211-34/+33
| | | | | | | | | | | | | | | | | | | | | | | insert_in_object_tree() This removes special-case for initalising the children array in insert_in_object_tree(). talloc_realloc() handles the intial allocate case perfectly well, so there is no need to have this duplicated. This also restores having just one place were the rest of the elements are intialised, to ensure uniform behaviour. To do this, we have to rework insert_in_object_tree to have only one output variable, both because having both root and new_node as output variables was too confusing, and because otherwise the two pointers were being allowed to point at the same memory. Andrew Bartlett Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
* libcli/security: Ensure to fill in remaining_access for the initial case ↵Andrew Bartlett2013-01-151-0/+1
| | | | | | | | | | | | (bug #9554 - CVE-2013-0172) It is critically important that we initialise this element as otherwise all access is permitted. Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org> (cherry picked from commit a75805490d96a85786287f5d0522dd7671d6816e)
* libcli/security/object_tree.c - remove unreachable statementMatthias Dieter Wallnöfer2010-11-291-1/+0
|
* Fix shadow warning for "access" variable.Jeremy Allison2010-10-191-3/+3
| | | | | Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Tue Oct 19 22:53:38 UTC 2010 on sn-devel-104
* libcli/auth Merge source4/libcli/security and util_sid.c into the common codeAndrew Bartlett2010-10-141-0/+121
This should ensure we only have one copy of these core functions in the tree. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>