summaryrefslogtreecommitdiffstats
path: root/source4
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2013-11-09 18:32:21 +0100
committerIra Cooper <ira@samba.org>2013-11-11 21:04:08 +0100
commit0c8d5df5cadf59bb7833ccdd8f9c710c61d55cca (patch)
treef8ce3027e924cdacd8d1724ccb6ae228f80ae18b /source4
parent096358f4e1b8000d1006293963f4c571ee6fc8cb (diff)
downloadsamba-0c8d5df5cadf59bb7833ccdd8f9c710c61d55cca.tar.gz
samba-0c8d5df5cadf59bb7833ccdd8f9c710c61d55cca.tar.xz
samba-0c8d5df5cadf59bb7833ccdd8f9c710c61d55cca.zip
dsdb: Fix Coverity ID 1034907 Dereference before null check
"module" has already been dereferenced by ldb_module_get_private(module) Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Ira Cooper <ira@samba.org>
Diffstat (limited to 'source4')
-rw-r--r--source4/dsdb/samdb/ldb_modules/partition.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source4/dsdb/samdb/ldb_modules/partition.c b/source4/dsdb/samdb/ldb_modules/partition.c
index 63835d8d627..39e85e47540 100644
--- a/source4/dsdb/samdb/ldb_modules/partition.c
+++ b/source4/dsdb/samdb/ldb_modules/partition.c
@@ -811,7 +811,7 @@ static int partition_start_trans(struct ldb_module *module)
/* Look at base DN */
/* Figure out which partition it is under */
/* Skip the lot if 'data' isn't here yet (initialization) */
- if ((module && ldb_module_flags(ldb_module_get_ctx(module)) & LDB_FLG_ENABLE_TRACING)) {
+ if (ldb_module_flags(ldb_module_get_ctx(module)) & LDB_FLG_ENABLE_TRACING) {
ldb_debug(ldb_module_get_ctx(module), LDB_DEBUG_TRACE, "partition_start_trans() -> (metadata partition)");
}
ret = ldb_next_start_trans(module);