diff options
| author | Andrew Bartlett <abartlet@samba.org> | 2014-04-09 12:43:54 +1200 |
|---|---|---|
| committer | Volker Lendecke <vl@samba.org> | 2014-04-09 18:26:40 +0200 |
| commit | 88ba81140eb98494fb48ac29b9450e582ceaf10d (patch) | |
| tree | 9c91faba220de516aca0873444a3f1189b2ea230 /source4/libcli | |
| parent | d9566085c68b9da6d46a5916a6cca33ca03befce (diff) | |
| download | samba-88ba81140eb98494fb48ac29b9450e582ceaf10d.tar.gz samba-88ba81140eb98494fb48ac29b9450e582ceaf10d.tar.xz samba-88ba81140eb98494fb48ac29b9450e582ceaf10d.zip | |
s4-wbclient: Fix wbc_sids_to_xids to correctly indicate the length of the SID list
This uses the fact that we know the end of the string in p to avoid
needing a strlen() call. Otherwise the winbindd validation that the
extra_data is terminated may fail, if the un-initiliased memory is not
zero.
Andrew Bartlett
Change-Id: I9b28068e4fbd3754c8d14724af93638d657810dd
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Wed Apr 9 18:26:40 CEST 2014 on sn-devel-104
Diffstat (limited to 'source4/libcli')
| -rw-r--r-- | source4/libcli/wbclient/wbclient.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source4/libcli/wbclient/wbclient.c b/source4/libcli/wbclient/wbclient.c index b5183be121b..61566233ec5 100644 --- a/source4/libcli/wbclient/wbclient.c +++ b/source4/libcli/wbclient/wbclient.c @@ -146,7 +146,7 @@ NTSTATUS wbc_sids_to_xids(struct tevent_context *ev, struct id_map *ids, req.cmd = WINBINDD_SIDS_TO_XIDS; req.pid = getpid(); req.extra_data.data = sids; - req.extra_len = sidslen; + req.extra_len = (p - sids); ret = wb_simple_trans(ev, fd, &req, mem_ctx, &resp, &err); if (ret == -1) { |