diff options
| author | Garming Sam <garming@catalyst.net.nz> | 2014-02-14 17:43:25 +1300 |
|---|---|---|
| committer | Andreas Schneider <asn@cryptomilk.org> | 2014-03-05 16:33:21 +0100 |
| commit | 4c9e0d5addd626769123299b593ec937ee52a0b5 (patch) | |
| tree | 494ae6df2d9bd26aa7695d58a31770a1dcf94dbe /source4/ldap_server | |
| parent | d2beff59ecd50ef2e77684bd0043c3d943a3b245 (diff) | |
| download | samba-4c9e0d5addd626769123299b593ec937ee52a0b5.tar.gz samba-4c9e0d5addd626769123299b593ec937ee52a0b5.tar.xz samba-4c9e0d5addd626769123299b593ec937ee52a0b5.zip | |
Remove NT_STATUS_IS_OK_RETURN macro from the codebase.
Following the current coding guidelines, it is considered bad practice to return from
within a macro and change control flow as they look like normal function calls.
Change-Id: I27e7597f4078f0a6c96b5dadd12454fffe33e6b2
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Diffstat (limited to 'source4/ldap_server')
| -rw-r--r-- | source4/ldap_server/ldap_extended.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/source4/ldap_server/ldap_extended.c b/source4/ldap_server/ldap_extended.c index 5cfa2d3b16f..338858f0347 100644 --- a/source4/ldap_server/ldap_extended.c +++ b/source4/ldap_server/ldap_extended.c @@ -185,7 +185,9 @@ NTSTATUS ldapsrv_ExtendedRequest(struct ldapsrv_call *call) * send and we need to return directly */ status = extended_ops[i].fn(call, reply, &error_str); - NT_STATUS_IS_OK_RETURN(status); + if (NT_STATUS_IS_OK(status)) { + return status; + } if (NT_STATUS_IS_LDAP(status)) { result = NT_STATUS_LDAP_CODE(status); |