summaryrefslogtreecommitdiffstats
path: root/source3
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2013-07-04 14:22:28 +0200
committerMichael Adam <obnox@samba.org>2014-05-24 13:48:14 +0200
commit8f3be3dcff8c42a93be3c0841b34250c795fb1c4 (patch)
treeeceecfee8964544dd0370356b39e66e9df1360b0 /source3
parentaaaff84b44dc211cf678b98320c55ca0e6eb3a46 (diff)
downloadsamba-8f3be3dcff8c42a93be3c0841b34250c795fb1c4.tar.gz
samba-8f3be3dcff8c42a93be3c0841b34250c795fb1c4.tar.xz
samba-8f3be3dcff8c42a93be3c0841b34250c795fb1c4.zip
Exit with ctdb_fatal if serverids_exist fails
The only reason why this could fail is a severe ctdb communications problem. The normal way to deal with this is ctdb_fatal. This avoids a confusing panic in get_share_mode_lock when ctdb is shutdown while this call happens. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Christof Schmitt <cs@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
Diffstat (limited to 'source3')
-rw-r--r--source3/lib/ctdbd_conn.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/source3/lib/ctdbd_conn.c b/source3/lib/ctdbd_conn.c
index fae3f907719..35845eda76d 100644
--- a/source3/lib/ctdbd_conn.c
+++ b/source3/lib/ctdbd_conn.c
@@ -1166,7 +1166,6 @@ bool ctdb_serverids_exist(struct ctdbd_connection *conn,
NTSTATUS status;
struct ctdb_vnn_list *vnns = NULL;
unsigned num_vnns;
- bool result = false;
if (!ctdb_collect_vnns(talloc_tos(), pids, num_pids,
&vnns, &num_vnns)) {
@@ -1303,10 +1302,11 @@ bool ctdb_serverids_exist(struct ctdbd_connection *conn,
num_received += 1;
}
- result = true;
-fail:
TALLOC_FREE(vnns);
- return result;
+ return true;
+fail:
+ cluster_fatal("serverids_exist failed");
+ return false;
#endif /* HAVE_CTDB_CONTROL_CHECK_SRVIDS_DECL */
}