summaryrefslogtreecommitdiffstats
path: root/source/utils/net_ads.c
diff options
context:
space:
mode:
authorAndrew Bartlett <abartlet@samba.org>2001-12-05 01:58:33 +0000
committerAndrew Bartlett <abartlet@samba.org>2001-12-05 01:58:33 +0000
commitea76a687fc2614912fd6b0458622495f9920749e (patch)
tree8197a62355f01c30d17b324ae126447c31545b2b /source/utils/net_ads.c
parent692c23fe86391204161adeb6cf9b8061d0121175 (diff)
downloadsamba-ea76a687fc2614912fd6b0458622495f9920749e.tar.gz
samba-ea76a687fc2614912fd6b0458622495f9920749e.tar.xz
samba-ea76a687fc2614912fd6b0458622495f9920749e.zip
Follow herb's suggestion and don't strdup a string to itself.
Diffstat (limited to 'source/utils/net_ads.c')
-rw-r--r--source/utils/net_ads.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/source/utils/net_ads.c b/source/utils/net_ads.c
index 1bfd5c637a8..a1ea063b208 100644
--- a/source/utils/net_ads.c
+++ b/source/utils/net_ads.c
@@ -156,6 +156,7 @@ static int net_ads_join(int argc, const char **argv)
ADS_STRUCT *ads;
int rc;
char *password;
+ char *tmp_password;
extern pstring global_myname;
NTSTATUS status;
@@ -163,9 +164,10 @@ static int net_ads_join(int argc, const char **argv)
DEBUG(1,("Failed to initialise secrets database\n"));
return -1;
}
-
- password = generate_random_str(15);
- password = strdup(password);
+
+
+ tmp_password = generate_random_str(15);
+ password = strdup(tmp_password);
if (!(ads = ads_startup())) return -1;