diff options
| author | Volker Lendecke <vl@sernet.de> | 2008-09-08 22:53:50 +0200 |
|---|---|---|
| committer | Karolin Seeger <kseeger@samba.org> | 2008-09-09 12:14:15 +0200 |
| commit | 4782c3ad8d661697646fcb093cc0d2708500c16e (patch) | |
| tree | 3a9cb4a6ddae0d26a2c183cf161432d6075a18a0 /source/smbd/trans2.c | |
| parent | ef6697435efba2afe15498caeb5daae7aea10604 (diff) | |
| download | samba-4782c3ad8d661697646fcb093cc0d2708500c16e.tar.gz samba-4782c3ad8d661697646fcb093cc0d2708500c16e.tar.xz samba-4782c3ad8d661697646fcb093cc0d2708500c16e.zip | |
Fix calculation of useable_space for trans2 and nttrans replies
When alignment was in place, we pretended to send more data/params according to
the param_offset/param_length and data_offset/data_length parameters than would
actually fit into the SMB according to the NBSS length field.
(cherry picked from commit 2ae870aead5e0ea7e7f9f6f9730f989ae34755b9)
Diffstat (limited to 'source/smbd/trans2.c')
| -rw-r--r-- | source/smbd/trans2.c | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/source/smbd/trans2.c b/source/smbd/trans2.c index 2cb826934e3..7753fad54f9 100644 --- a/source/smbd/trans2.c +++ b/source/smbd/trans2.c @@ -737,14 +737,16 @@ void send_trans2_replies(connection_struct *conn, + alignment_offset + data_alignment_offset); - /* useable_space can never be more than max_send minus the alignment offset. */ - - useable_space = MIN(useable_space, max_send - (alignment_offset+data_alignment_offset)); + if (useable_space < 0) { + DEBUG(0, ("send_trans2_replies failed sanity useable_space " + "= %d!!!", useable_space)); + exit_server_cleanly("send_trans2_replies: Not enough space"); + } while (params_to_send || data_to_send) { /* Calculate whether we will totally or partially fill this packet */ - total_sent_thistime = params_to_send + data_to_send + alignment_offset + data_alignment_offset; + total_sent_thistime = params_to_send + data_to_send; /* We can never send more than useable_space */ /* @@ -754,9 +756,10 @@ void send_trans2_replies(connection_struct *conn, * are sent here. Fix from Marc_Jacobsen@hp.com. */ - total_sent_thistime = MIN(total_sent_thistime, useable_space+ alignment_offset + data_alignment_offset); + total_sent_thistime = MIN(total_sent_thistime, useable_space); - reply_outbuf(req, 10, total_sent_thistime); + reply_outbuf(req, 10, total_sent_thistime + alignment_offset + + data_alignment_offset); /* Set total params and data to be sent */ SSVAL(req->outbuf,smb_tprcnt,paramsize); |