summaryrefslogtreecommitdiffstats
path: root/source/rpcclient/rpcclient.c
diff options
context:
space:
mode:
authorVolker Lendecke <vlendec@samba.org>2006-03-12 17:44:00 +0000
committerGerald (Jerry) Carter <jerry@samba.org>2007-10-10 11:15:20 -0500
commitd47ee82f068f1dfbae4a1c81e6bd765d5d36f09f (patch)
treea450ee9ded96c93d5808bc10e3750a5cc52f90e2 /source/rpcclient/rpcclient.c
parentf2a24b63e395d5cbb9b81521cd7ffe904821b727 (diff)
downloadsamba-d47ee82f068f1dfbae4a1c81e6bd765d5d36f09f.tar.gz
samba-d47ee82f068f1dfbae4a1c81e6bd765d5d36f09f.tar.xz
samba-d47ee82f068f1dfbae4a1c81e6bd765d5d36f09f.zip
r14245: We've dereferenced argv before, no point in checking.
Fix Coverity bug # 144. Volker
Diffstat (limited to 'source/rpcclient/rpcclient.c')
-rw-r--r--source/rpcclient/rpcclient.c12
1 files changed, 5 insertions, 7 deletions
diff --git a/source/rpcclient/rpcclient.c b/source/rpcclient/rpcclient.c
index 3f493ce2c50..8d70c6030a3 100644
--- a/source/rpcclient/rpcclient.c
+++ b/source/rpcclient/rpcclient.c
@@ -663,13 +663,11 @@ out_free:
}
*/
- if (argv) {
- /* NOTE: popt allocates the whole argv, including the
- * strings, as a single block. So a single free is
- * enough to release it -- we don't free the
- * individual strings. rtfm. */
- free(argv);
- }
+ /* NOTE: popt allocates the whole argv, including the
+ * strings, as a single block. So a single free is
+ * enough to release it -- we don't free the
+ * individual strings. rtfm. */
+ free(argv);
return result;
}