diff options
| author | Jeremy Allison <jra@samba.org> | 2000-06-24 00:15:08 +0000 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2000-06-24 00:15:08 +0000 |
| commit | 151b131ee01ef916c072bcdaa9943a2e984a0f45 (patch) | |
| tree | 2bfcdd7101b70b40463dd5b8dff1d9f8f6bf3f5d /source/rpc_parse/parse_spoolss.c | |
| parent | 2aa21db960666736331b18956422b7c13aad0f0f (diff) | |
| download | samba-151b131ee01ef916c072bcdaa9943a2e984a0f45.tar.gz samba-151b131ee01ef916c072bcdaa9943a2e984a0f45.tar.xz samba-151b131ee01ef916c072bcdaa9943a2e984a0f45.zip | |
lib/util_sid.c: Uninitialized memory read.
rpc_parse/parse_spoolss.c: Added note about prs_align when marshalling a SEC_DESC...
rpc_server/srv_lsa.c: Tim - your changes broke the display of the 'everyone' group
when doing file access with no winbindd running. This is a partial
fix - more when I have analysed this more.
rpc_server/srv_spoolss_nt.c: Fix for the 'change driver' problem ! Hurrah !
Jeremy.
Diffstat (limited to 'source/rpc_parse/parse_spoolss.c')
| -rw-r--r-- | source/rpc_parse/parse_spoolss.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/source/rpc_parse/parse_spoolss.c b/source/rpc_parse/parse_spoolss.c index d5f3b1c7c8f..86fee3017fe 100644 --- a/source/rpc_parse/parse_spoolss.c +++ b/source/rpc_parse/parse_spoolss.c @@ -1694,7 +1694,7 @@ BOOL new_smb_io_printer_info_0(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_0 *i ********************************************************************/ BOOL new_smb_io_printer_info_1(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_1 *info, int depth) { - prs_struct *ps=&(buffer->prs); + prs_struct *ps=&buffer->prs; prs_debug(ps, depth, desc, "new_smb_io_printer_info_1"); depth++; @@ -1718,7 +1718,7 @@ BOOL new_smb_io_printer_info_1(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_1 *i ********************************************************************/ BOOL new_smb_io_printer_info_2(char *desc, NEW_BUFFER *buffer, PRINTER_INFO_2 *info, int depth) { - prs_struct *ps=&(buffer->prs); + prs_struct *ps=&buffer->prs; prs_debug(ps, depth, desc, "new_smb_io_printer_info_2"); depth++; @@ -2355,6 +2355,7 @@ uint32 spoolss_size_printer_info_2(PRINTER_INFO_2 *info) uint32 size=0; size += 4; + /* JRA !!!! TESTME - WHAT ABOUT prs_align.... !!! */ size += sec_desc_size( info->secdesc ); size+=size_of_device_mode( info->devmode ); @@ -2389,6 +2390,7 @@ return the size required by a struct in the stream uint32 spoolss_size_printer_info_3(PRINTER_INFO_3 *info) { /* The 4 is for the self relative pointer.. */ + /* JRA !!!! TESTME - WHAT ABOUT prs_align.... !!! */ return 4 + (uint32)sec_desc_size( info->secdesc ); } |