diff options
| author | Andrew Tridgell <tridge@samba.org> | 1998-05-11 06:38:36 +0000 |
|---|---|---|
| committer | Andrew Tridgell <tridge@samba.org> | 1998-05-11 06:38:36 +0000 |
| commit | ee09e9dadb69aaba5a751dd20ccc6d587d841bd6 (patch) | |
| tree | b7d08dcf7d06d74c7bba90655f720c14cff8981a /source/printing | |
| parent | 6b0c1733d2ebf3b8f09f3bf88b8648d8b371bb1f (diff) | |
| download | samba-ee09e9dadb69aaba5a751dd20ccc6d587d841bd6.tar.gz samba-ee09e9dadb69aaba5a751dd20ccc6d587d841bd6.tar.xz samba-ee09e9dadb69aaba5a751dd20ccc6d587d841bd6.zip | |
changed to use slprintf() instead of sprintf() just about
everywhere. I've implemented slprintf() as a bounds checked sprintf()
using mprotect() and a non-writeable page.
This should prevent any sprintf based security holes.
Diffstat (limited to 'source/printing')
| -rw-r--r-- | source/printing/printing.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source/printing/printing.c b/source/printing/printing.c index c7db5744e26..278c54933d3 100644 --- a/source/printing/printing.c +++ b/source/printing/printing.c @@ -1058,7 +1058,7 @@ int get_printqueue(int snum,int cnum,print_queue_struct **queue, standard_sub(cnum,syscmd); - sprintf(outfile,"%s/lpq.%08x",tmpdir(),str_checksum(syscmd)); + slprintf(outfile,sizeof(outfile)-1, "%s/lpq.%08x",tmpdir(),str_checksum(syscmd)); if (!lpq_cache_reset[snum] && cachetime && !stat(outfile,&sbuf)) { |