summaryrefslogtreecommitdiffstats
path: root/source/nmbd
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2007-06-20 17:38:42 +0000
committerGerald (Jerry) Carter <jerry@samba.org>2007-10-10 12:23:28 -0500
commit073fdc5a58139796dbaa7ea9833dca5308f11282 (patch)
tree1068f75520b4bc492b3d26aa711c847d3aaccde9 /source/nmbd
parent3695a66166c6aa88051b21ad40a19f1cc8b87c7b (diff)
downloadsamba-073fdc5a58139796dbaa7ea9833dca5308f11282.tar.gz
samba-073fdc5a58139796dbaa7ea9833dca5308f11282.tar.xz
samba-073fdc5a58139796dbaa7ea9833dca5308f11282.zip
r23554: Fix bug #4711 by makeing cli_connect return an NTSTATUS.
Long overdue fix.... Jeremy.
Diffstat (limited to 'source/nmbd')
-rw-r--r--source/nmbd/nmbd_synclists.c8
1 files changed, 7 insertions, 1 deletions
diff --git a/source/nmbd/nmbd_synclists.c b/source/nmbd/nmbd_synclists.c
index 7fe39676c6f..fa1a41a5af7 100644
--- a/source/nmbd/nmbd_synclists.c
+++ b/source/nmbd/nmbd_synclists.c
@@ -71,6 +71,7 @@ static void sync_child(char *name, int nm_type,
struct cli_state *cli;
uint32 local_type = local ? SV_TYPE_LOCAL_LIST_ONLY : 0;
struct nmb_name called, calling;
+ NTSTATUS status;
/* W2K DMB's return empty browse lists on port 445. Use 139.
* Patch from Andy Levine andyl@epicrealm.com.
@@ -81,7 +82,12 @@ static void sync_child(char *name, int nm_type,
return;
}
- if (!cli_set_port(cli, 139) || !cli_connect(cli, name, &ip)) {
+ if (!cli_set_port(cli, 139)) {
+ return;
+ }
+
+ status = cli_connect(cli, name, &ip);
+ if (!NT_STATUS_IS_OK(status)) {
return;
}