diff options
| author | Martin Pool <mbp@samba.org> | 2002-03-20 06:57:03 +0000 |
|---|---|---|
| committer | Martin Pool <mbp@samba.org> | 2002-03-20 06:57:03 +0000 |
| commit | 098905bea29c7d5b886809d431294ddf2fc1e152 (patch) | |
| tree | 5b99b8876978459673bfb690193365a51bc66d77 /source/nmbd/asyncdns.c | |
| parent | b1b7ae8bcfafc92c2d475908f4220f3f1ff941a1 (diff) | |
| download | samba-098905bea29c7d5b886809d431294ddf2fc1e152.tar.gz samba-098905bea29c7d5b886809d431294ddf2fc1e152.tar.xz samba-098905bea29c7d5b886809d431294ddf2fc1e152.zip | |
Add assertions that kill() is never accidentally passed a non-positive
pid. This follows a bug in rsync where it would accidentally
kill(-1), removing all the user's processes. I can't see any way this
would directly happen in Samba, but having the assertions seems
beneficial.
http://cvs.samba.org/cgi-bin/cvsweb/rsync/util.c.diff?r1=1.108&r2=1.109&f=h
Diffstat (limited to 'source/nmbd/asyncdns.c')
| -rw-r--r-- | source/nmbd/asyncdns.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/source/nmbd/asyncdns.c b/source/nmbd/asyncdns.c index c5ff718836c..6c2f8de3b18 100644 --- a/source/nmbd/asyncdns.c +++ b/source/nmbd/asyncdns.c @@ -120,8 +120,9 @@ static void sig_term(int sig) void kill_async_dns_child(void) { - if(child_pid != 0 && child_pid != -1) - kill(child_pid, SIGTERM); + if (child_pid > 0) { + kill(child_pid, SIGTERM); + } } /*************************************************************************** |