diff options
author | Jeremy Allison <jra@samba.org> | 2006-12-10 05:23:47 +0000 |
---|---|---|
committer | Gerald (Jerry) Carter <jerry@samba.org> | 2007-10-10 12:16:24 -0500 |
commit | f83b6de44f1058811ff94ac72a8a71bd8e49e4e8 (patch) | |
tree | 39402e175e49fa3093b5ca7fdcbf701d1d3ddc30 /source/include | |
parent | 2c59c4dddceb9cb12848d7ee48257c5e93ea2667 (diff) | |
download | samba-f83b6de44f1058811ff94ac72a8a71bd8e49e4e8.tar.gz samba-f83b6de44f1058811ff94ac72a8a71bd8e49e4e8.tar.xz samba-f83b6de44f1058811ff94ac72a8a71bd8e49e4e8.zip |
r20098: Properly fix issues with create_token_from_username()
reported by James. Ensure that this function allocates
everything on the temporary context except the return
memory. Never call this with a null mem context, and
now use conn->mem_ctx instead in smbd/service.c.
Remove separate free functions for conn->ngroups
and conn->nt_user_token as they are now always
talloc'ed off the conn->mem_ctx. Future optimization
will be to remove conn->mem_ctx and make all objects
pointed to in the conn struct talloc'ed off conn itself.
Easy to free then :-).
Jeremy.
Diffstat (limited to 'source/include')
-rw-r--r-- | source/include/smb.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/source/include/smb.h b/source/include/smb.h index 765e153b379..aefc06548e3 100644 --- a/source/include/smb.h +++ b/source/include/smb.h @@ -547,7 +547,7 @@ struct share_iterator { typedef struct connection_struct { struct connection_struct *next, *prev; - TALLOC_CTX *mem_ctx; + TALLOC_CTX *mem_ctx; /* long-lived memory context for things hanging off this struct. */ unsigned cnum; /* an index passed over the wire */ struct share_params *params; BOOL force_user; |