Rework much of the service.c code:

The aim of this execise is to give the 'security>=user' code a straight paper
path.  Security=share will sill call authorise_login(), but otherwise we avoid
that mess.

This allow *much* more accurate error code reporting, beocuse we don't start
pretending that we can use the (nonexistant) password etc.

Also in this patch is code to create the 'homes' share at session setup time
(as we have done in the past - been broken recently) and to record this on
the user's vuser struct for later reference.  The changes here should also
allow for much better use of %H (some more changes to come here).

The service.c changes move a lot of code around, but are not as drastric
as they look...

(Also included is a fix to srv_srvsvc_nt.c where 'total_entries' not
'*total_entries' was compared).

This code is needs testing, but passes my basic tests.

I expect we have lost some functionality, but the stuff I had expected
to loose was already broken before I started.  In particular, we don't 'fall
back' to guest if the user cannot access a share (for security=user).  If you
want this kind of stuff then you really want security=share anyway.

Andrew Bartlett

1 files changed, 3 insertions, 0 deletions

diff --git a/source/include/smb.h b/source/include/smb.h
index 6678a8674df..c15b15564fb 100644
--- a/source/include/smb.h
+++ b/source/include/smb.h
@@ -1605,6 +1605,9 @@ typedef struct user_struct
 	uint8 session_key[16];
 
 	int session_id; /* used by utmp and pam session code */
+	
+	int homes_snum;
+
 } user_struct;