summaryrefslogtreecommitdiffstats
path: root/source/gtk/tools/gregedit.c
diff options
context:
space:
mode:
authorAndrew Tridgell <tridge@samba.org>2006-09-16 16:59:37 +0000
committerAndrew Tridgell <tridge@samba.org>2006-09-16 16:59:37 +0000
commit638ece0f51a1f23a40ac205e7a0148119a55e938 (patch)
tree50cda47dc715fd1ebb0fd0c1b8557286e6f6a6d9 /source/gtk/tools/gregedit.c
parentd0215a51f1855697ec25e29d8051d351806076e0 (diff)
downloadsamba-638ece0f51a1f23a40ac205e7a0148119a55e938.tar.gz
samba-638ece0f51a1f23a40ac205e7a0148119a55e938.tar.xz
samba-638ece0f51a1f23a40ac205e7a0148119a55e938.zip
r18584: found one of the fd leaks. The registry backend was using a
talloc(NULL, xxx) to allocate the registry context. That had two consequences 1) it was a massive memory leak, as all winreg operations leaked their entire context (including an open ldb database) every time 2) event_context_find() never found the exsting event context, so we used a new event context each time, which called epoll_create() each time, which caused a fd to be allocated
Diffstat (limited to 'source/gtk/tools/gregedit.c')
-rw-r--r--source/gtk/tools/gregedit.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/source/gtk/tools/gregedit.c b/source/gtk/tools/gregedit.c
index e0717187d97..cf03eebec84 100644
--- a/source/gtk/tools/gregedit.c
+++ b/source/gtk/tools/gregedit.c
@@ -385,7 +385,7 @@ static void on_open_gconf_activate(GtkMenuItem *menuitem, gpointer user_data)
static void on_open_local_activate(GtkMenuItem *menuitem, gpointer user_data)
{
- WERROR error = reg_open_local(&registry, NULL, NULL);
+ WERROR error = reg_open_local(NULL, &registry, NULL, NULL);
if(!W_ERROR_IS_OK(error)) {
gtk_show_werror(mainwin, "Error while opening local registry", error);
return;
@@ -953,7 +953,7 @@ static GtkWidget* create_savefilewin (void)
static int gregedit_load_defaults(void)
{
- WERROR error = reg_open_local(&registry, NULL, NULL);
+ WERROR error = reg_open_local(NULL, &registry, NULL, NULL);
if(!W_ERROR_IS_OK(error)) {
gtk_show_werror(mainwin, "Error while loading local registry", error);
return -1;