diff options
| author | Herb Lewis <herb@samba.org> | 2002-08-30 18:56:46 +0000 |
|---|---|---|
| committer | Herb Lewis <herb@samba.org> | 2002-08-30 18:56:46 +0000 |
| commit | cf9bb66aa9c3217cb8394058c65c84ffc6ae269a (patch) | |
| tree | 0b5a307b9676bb24306dccfa383c0b79b97eb32e /source/auth/auth_util.c | |
| parent | 4e836c4ce2b51e42ab4f29c6c916fe6a73a58654 (diff) | |
| download | samba-cf9bb66aa9c3217cb8394058c65c84ffc6ae269a.tar.gz samba-cf9bb66aa9c3217cb8394058c65c84ffc6ae269a.tar.xz samba-cf9bb66aa9c3217cb8394058c65c84ffc6ae269a.zip | |
off by one in writing to malloced array. this fixes smbd crash I saw at
the CIFS conference - finally got purify working
Diffstat (limited to 'source/auth/auth_util.c')
| -rw-r--r-- | source/auth/auth_util.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/source/auth/auth_util.c b/source/auth/auth_util.c index 118126a2756..5ae942fac70 100644 --- a/source/auth/auth_util.c +++ b/source/auth/auth_util.c @@ -980,8 +980,8 @@ NTSTATUS make_server_info_info3(TALLOC_CTX *mem_ctx, /* and create (by appending rids) the 'domain' sids */ for (i = 0; i < info3->num_groups2; i++) { - sid_copy(&all_group_SIDs[i+n_lgroupSIDs+1], &(info3->dom_sid.sid)); - if (!sid_append_rid(&all_group_SIDs[i+n_lgroupSIDs+1], info3->gids[i].g_rid)) { + sid_copy(&all_group_SIDs[i+n_lgroupSIDs], &(info3->dom_sid.sid)); + if (!sid_append_rid(&all_group_SIDs[i+n_lgroupSIDs], info3->gids[i].g_rid)) { nt_status = NT_STATUS_INVALID_PARAMETER; DEBUG(3,("create_nt_token_info3: could not append additional group rid 0x%x\n", info3->gids[i].g_rid)); |