diff options
| author | Ira Cooper <ira@samba.org> | 2014-02-13 14:45:23 -0500 |
|---|---|---|
| committer | Ira Cooper <ira@samba.org> | 2014-02-24 11:56:37 +0100 |
| commit | 8cd8aa6686c21e8c43a6d14c0ae1a21954d6e8cd (patch) | |
| tree | 229efb6e9a8d76b66c4f2b3caf5e1c121ea09d73 /libcli | |
| parent | 14063719e0b21da438179f0bb02b8c9d948d2dbb (diff) | |
| download | samba-8cd8aa6686c21e8c43a6d14c0ae1a21954d6e8cd.tar.gz samba-8cd8aa6686c21e8c43a6d14c0ae1a21954d6e8cd.tar.xz samba-8cd8aa6686c21e8c43a6d14c0ae1a21954d6e8cd.zip | |
libcli: Overflow array index read possible, in auth code.
Changed the if condtion to detect when we'd improperly overflow.
Coverity-Id: 1167990
Signed-off-by: Ira Cooper <ira@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Ira Cooper <ira@samba.org>
Autobuild-Date(master): Mon Feb 24 11:56:38 CET 2014 on sn-devel-104
Diffstat (limited to 'libcli')
| -rw-r--r-- | libcli/auth/netlogon_creds_cli.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libcli/auth/netlogon_creds_cli.c b/libcli/auth/netlogon_creds_cli.c index d73335da1d6..472a45272c7 100644 --- a/libcli/auth/netlogon_creds_cli.c +++ b/libcli/auth/netlogon_creds_cli.c @@ -1770,7 +1770,7 @@ struct tevent_req *netlogon_creds_cli_ServerPasswordSet_send(TALLOC_CTX *mem_ctx uint32_t ofs = 512 - len; uint8_t *p; - if (ofs < 12) { + if (len > 500) { tevent_req_nterror(req, NT_STATUS_INVALID_PARAMETER_MIX); return tevent_req_post(req, ev); } |