summaryrefslogtreecommitdiffstats
path: root/libcli
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2014-05-26 20:57:31 +0000
committerDavid Disseldorp <ddiss@samba.org>2014-05-27 17:32:12 +0200
commit80ef004721e6d88bc87e4d1a1e100cb87e81cc93 (patch)
tree2a0ea307beed63375d758e9f83dc273f4671ede4 /libcli
parent9487785e89e9c6f920c6284a1bd1165bd7d80cc0 (diff)
downloadsamba-80ef004721e6d88bc87e4d1a1e100cb87e81cc93.tar.gz
samba-80ef004721e6d88bc87e4d1a1e100cb87e81cc93.tar.xz
samba-80ef004721e6d88bc87e4d1a1e100cb87e81cc93.zip
libcli: Avoid a talloc/free
Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: David Disseldorp <ddiss@samba.org>
Diffstat (limited to 'libcli')
-rw-r--r--libcli/security/security_token.c10
1 files changed, 6 insertions, 4 deletions
diff --git a/libcli/security/security_token.c b/libcli/security/security_token.c
index 40f13820eec..95a09b33783 100644
--- a/libcli/security/security_token.c
+++ b/libcli/security/security_token.c
@@ -84,12 +84,14 @@ bool security_token_is_sid(const struct security_token *token, const struct dom_
bool security_token_is_sid_string(const struct security_token *token, const char *sid_string)
{
bool ret;
- struct dom_sid *sid = dom_sid_parse_talloc(NULL, sid_string);
- if (!sid) return false;
+ struct dom_sid sid;
- ret = security_token_is_sid(token, sid);
+ ret = dom_sid_parse(sid_string, &sid);
+ if (!ret) {
+ return false;
+ }
- talloc_free(sid);
+ ret = security_token_is_sid(token, &sid);
return ret;
}