common: Detailed platform-specific FIXME

Signed-off-by: Mathieu Parent <math.parent@gmail.com>

(This used to be ctdb commit d202b2fdd4fd70172e5e44583627b57a1b7ad2ed)

4 files changed, 22 insertions, 18 deletions

diff --git a/ctdb/common/system_aix.c b/ctdb/common/system_aix.c
index 16b627ca479..3f2e92aa6c6 100644
--- a/ctdb/common/system_aix.c
+++ b/ctdb/common/system_aix.c
@@ -359,6 +359,7 @@ int ctdb_sys_read_tcp_packet(int s, void *private_data,
 
 bool ctdb_sys_check_iface_exists(const char *iface)
 {
+	/* FIXME AIX: Interface always considered present */
 	return true;
 }
 
@@ -375,18 +376,18 @@ int ctdb_get_peer_pid(const int fd, pid_t *peer_pid)
 
 char *ctdb_get_process_name(pid_t pid)
 {
-	/* FIXME: not implemented */
+	/* FIXME AIX: get_process_name not implemented */
 	return NULL;
 }
 
 bool ctdb_get_lock_info(pid_t req_pid, struct ctdb_lock_info *lock_info)
 {
-	/* FIXME: not implemented */
+	/* FIXME AIX: get_lock_info not implemented */
 	return false;
 }
 
 bool ctdb_get_blocker_pid(struct ctdb_lock_info *reqlock, pid_t *blocker_pid)
 {
-	/* FIXME: not implemented */
+	/* FIXME AIX: get_blocker_pid not implemented */
 	return false;
 }
diff --git a/ctdb/common/system_freebsd.c b/ctdb/common/system_freebsd.c
index 37f1c74b451..2fb3f45ebd0 100644
--- a/ctdb/common/system_freebsd.c
+++ b/ctdb/common/system_freebsd.c
@@ -75,7 +75,7 @@ static uint16_t tcp_checksum6(uint16_t *data, size_t n, struct ip6_hdr *ip6)
  */
 int ctdb_sys_send_arp(const ctdb_sock_addr *addr, const char *iface)
 {
-	/* FIXME We dont do gratuitous arp on Hurd yet */
+	/* FIXME FreeBSD: We dont do gratuitous arp yet */
 	return 0;
 }
 
@@ -360,29 +360,30 @@ int ctdb_sys_read_tcp_packet(int s, void *private_data,
 
 bool ctdb_sys_check_iface_exists(const char *iface)
 {
+	/* FIXME FreeBSD: Interface always considered present */
 	return true;
 }
 
 int ctdb_get_peer_pid(const int fd, pid_t *peer_pid)
 {
-	/* FIXME not implemented */
+	/* FIXME FreeBSD: get_peer_pid not implemented */
 	return 1;
 }
 
 char *ctdb_get_process_name(pid_t pid)
 {
-	/* FIXME: not implemented */
+	/* FIXME FreeBSD: get_process_name not implemented */
 	return NULL;
 }
 
 bool ctdb_get_lock_info(pid_t req_pid, struct ctdb_lock_info *lock_info)
 {
-	/* FIXME: not implemented */
+	/* FIXME FreeBSD: get_lock_info not implemented */
 	return false;
 }
 
 bool ctdb_get_blocker_pid(struct ctdb_lock_info *reqlock, pid_t *blocker_pid)
 {
-	/* FIXME: not implemented */
+	/* FIXME FreeBSD: get_blocker_pid not implemented */
 	return false;
 }
diff --git a/ctdb/common/system_gnu.c b/ctdb/common/system_gnu.c
index 8a3b5b1e540..b141da39f90 100644
--- a/ctdb/common/system_gnu.c
+++ b/ctdb/common/system_gnu.c
@@ -74,7 +74,7 @@ static uint16_t tcp_checksum6(uint16_t *data, size_t n, struct ip6_hdr *ip6)
  */
 int ctdb_sys_send_arp(const ctdb_sock_addr *addr, const char *iface)
 {
-	/* FIXME We dont do gratuitous arp on Hurd yet */
+	/* FIXME GNU/Hurd: We dont do gratuitous arp yet */
 	return 0;
 }
 
@@ -353,29 +353,30 @@ int ctdb_sys_read_tcp_packet(int s, void *private_data,
 
 bool ctdb_sys_check_iface_exists(const char *iface)
 {
+	/* FIXME GNU/Hurd: Interface always considered present */
 	return true;
 }
 
 int ctdb_get_peer_pid(const int fd, pid_t *peer_pid)
 {
-	/* FIXME not implemented */
+	/* FIXME GNU/Hurd: get_peer_pid not implemented */
 	return 1;
 }
 
 char *ctdb_get_process_name(pid_t pid)
 {
-	/* FIXME: not implemented */
+	/* FIXME GNU/Hurd: get_process_name not implemented */
 	return NULL;
 }
 
 bool ctdb_get_lock_info(pid_t req_pid, struct ctdb_lock_info *lock_info)
 {
-	/* FIXME: not implemented */
+	/* FIXME GNU/Hurd: get_lock_info not implemented */
 	return false;
 }
 
 bool ctdb_get_blocker_pid(struct ctdb_lock_info *reqlock, pid_t *blocker_pid)
 {
-	/* FIXME: not implemented */
+	/* FIXME GNU/Hurd: get_blocker_pid not implemented */
 	return false;
 }
diff --git a/ctdb/common/system_kfreebsd.c b/ctdb/common/system_kfreebsd.c
index 55958651866..85442ed28d5 100644
--- a/ctdb/common/system_kfreebsd.c
+++ b/ctdb/common/system_kfreebsd.c
@@ -74,7 +74,7 @@ static uint16_t tcp_checksum6(uint16_t *data, size_t n, struct ip6_hdr *ip6)
  */
 int ctdb_sys_send_arp(const ctdb_sock_addr *addr, const char *iface)
 {
-	/* FIXME We dont do gratuitous arp on Hurd yet */
+	/* FIXME kFreeBSD: We dont do gratuitous arp yet */
 	return 0;
 }
 
@@ -353,29 +353,30 @@ int ctdb_sys_read_tcp_packet(int s, void *private_data,
 
 bool ctdb_sys_check_iface_exists(const char *iface)
 {
+	/* FIXME kFreeBSD: Interface always considered present */
 	return true;
 }
 
 int ctdb_get_peer_pid(const int fd, pid_t *peer_pid)
 {
-	/* FIXME not implemented */
+	/* FIXME kFreeBSD: get_peer_pid not implemented */
 	return 1;
 }
 
 char *ctdb_get_process_name(pid_t pid)
 {
-	/* FIXME: not implemented */
+	/* FIXME kFreeBSD: get_process_name not implemented */
 	return NULL;
 }
 
 bool ctdb_get_lock_info(pid_t req_pid, struct ctdb_lock_info *lock_info)
 {
-	/* FIXME: not implemented */
+	/* FIXME kFreeBSD: get_lock_info not implemented */
 	return false;
 }
 
 bool ctdb_get_blocker_pid(struct ctdb_lock_info *reqlock, pid_t *blocker_pid)
 {
-	/* FIXME: not implemented */
+	/* FIXME kFreeBSD: get_blocker_pid not implemented */
 	return false;
 }