diff options
| author | Jeremy Allison <jra@samba.org> | 2001-09-06 15:48:32 +0000 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2001-09-06 15:48:32 +0000 |
| commit | dd48ed9b76b626791deac706130f9eb8cc37cf12 (patch) | |
| tree | 864ef53320aa5ef79be2edf280950f56c6844270 | |
| parent | 04ae1b3f9cbaa86f3a71497dfe7d0af08cbfb391 (diff) | |
| download | samba-dd48ed9b76b626791deac706130f9eb8cc37cf12.tar.gz samba-dd48ed9b76b626791deac706130f9eb8cc37cf12.tar.xz samba-dd48ed9b76b626791deac706130f9eb8cc37cf12.zip | |
Fixed O(N^2) talloc loop when allocating printer name memory - fix from
Richard Bollinger <rabollinger@home.com>.
Jeremy.
| -rw-r--r-- | source/param/loadparm.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/source/param/loadparm.c b/source/param/loadparm.c index 16626c137f4..a0b10a2ad05 100644 --- a/source/param/loadparm.c +++ b/source/param/loadparm.c @@ -3417,8 +3417,8 @@ int lp_servicenumber(char *pszServiceName) int iService; for (iService = iNumServices - 1; iService >= 0; iService--) - if (VALID(iService) && - strequal(lp_servicename(iService), pszServiceName)) + if (VALID(iService) && ServicePtrs[iService]->szService && + strequal(ServicePtrs[iService]->szService, pszServiceName)) break; if (iService < 0) |