summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2006-03-12 19:16:45 +0000
committerGerald (Jerry) Carter <jerry@samba.org>2007-10-10 11:15:20 -0500
commitca96c7be778d01594a540917acd3c5c218d6459c (patch)
tree8466ee0cdab9e136294fbe0c333e4bb9c1ee67b5
parent84e9e73f3c71a0ccef76d56bc72dcd21160ed286 (diff)
downloadsamba-ca96c7be778d01594a540917acd3c5c218d6459c.tar.gz
samba-ca96c7be778d01594a540917acd3c5c218d6459c.tar.xz
samba-ca96c7be778d01594a540917acd3c5c218d6459c.zip
r14250: Fix coverity bug #107. Resource leak on error path.
Jeremy.
-rw-r--r--source/rpc_server/srv_spoolss_nt.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/source/rpc_server/srv_spoolss_nt.c b/source/rpc_server/srv_spoolss_nt.c
index 2424c46691e..951757d4c8a 100644
--- a/source/rpc_server/srv_spoolss_nt.c
+++ b/source/rpc_server/srv_spoolss_nt.c
@@ -4862,8 +4862,10 @@ static WERROR getprinter_level_5(Printer_entry *print_hnd, int snum, RPC_BUFFER
if((printer=SMB_MALLOC_P(PRINTER_INFO_5))==NULL)
return WERR_NOMEM;
- if (!construct_printer_info_5(print_hnd, printer, snum))
+ if (!construct_printer_info_5(print_hnd, printer, snum)) {
+ free_printer_info_5(printer);
return WERR_NOMEM;
+ }
/* check the required size. */
*needed += spoolss_size_printer_info_5(printer);