diff options
author | Andrew Bartlett <abartlet@samba.org> | 2003-02-24 11:23:15 +0000 |
---|---|---|
committer | Andrew Bartlett <abartlet@samba.org> | 2003-02-24 11:23:15 +0000 |
commit | c26881633d8a7f6d9b9ed9c6a97ce2b45bf2b317 (patch) | |
tree | fe3be38427cdab0e8a6c885fc329983e3c88246a | |
parent | a47dee787413daaf0b550a47bbd78125490c356e (diff) | |
download | samba-c26881633d8a7f6d9b9ed9c6a97ce2b45bf2b317.tar.gz samba-c26881633d8a7f6d9b9ed9c6a97ce2b45bf2b317.tar.xz samba-c26881633d8a7f6d9b9ed9c6a97ce2b45bf2b317.zip |
Move off-by-one buggy malloc()/safe_strcpy() combination to strdup() instead.
Andrew Bartlett
-rw-r--r-- | source/lib/util_getent.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/source/lib/util_getent.c b/source/lib/util_getent.c index 7d45287bbad..32641dbf83b 100644 --- a/source/lib/util_getent.c +++ b/source/lib/util_getent.c @@ -224,18 +224,16 @@ static struct sys_userlist *add_members_to_userlist(struct sys_userlist *list_he for (i = 0; i < num_users; i++) { struct sys_userlist *entry = (struct sys_userlist *)malloc(sizeof(*entry)); - size_t len = strlen(grp->gr_mem[i])+1; if (entry == NULL) { free_userlist(list_head); return NULL; } - entry->unix_name = (char *)malloc(len); + entry->unix_name = (char *)strdup(grp->gr_mem[i]); if (entry->unix_name == NULL) { SAFE_FREE(entry); free_userlist(list_head); return NULL; } - safe_strcpy(entry->unix_name, grp->gr_mem[i],len); DLIST_ADD(list_head, entry); } return list_head; |