summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJeremy Allison <jra@samba.org>2006-03-13 01:08:27 +0000
committerGerald (Jerry) Carter <jerry@samba.org>2007-10-10 11:15:22 -0500
commitaeae20a8d9f3658acb8edd373eb601bdf7eab98b (patch)
treed2904067b9a4344eb1dc7f5ea5528768910a5828
parentd2be8163f2cf69681150ed7de720a37ffaa8e937 (diff)
downloadsamba-aeae20a8d9f3658acb8edd373eb601bdf7eab98b.tar.gz
samba-aeae20a8d9f3658acb8edd373eb601bdf7eab98b.tar.xz
samba-aeae20a8d9f3658acb8edd373eb601bdf7eab98b.zip
r14275: Shut-up coverity false positive (bug #199) by making an assertion
explicit. Jeremy.
-rw-r--r--source/nsswitch/winbindd_pam.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/source/nsswitch/winbindd_pam.c b/source/nsswitch/winbindd_pam.c
index fdc6e071190..becfc37c44b 100644
--- a/source/nsswitch/winbindd_pam.c
+++ b/source/nsswitch/winbindd_pam.c
@@ -1137,6 +1137,13 @@ process_result:
DOM_SID user_sid;
+ /* In all codepaths were result == NT_STATUS_OK info3 must have
+ been initialized. */
+ if (!info3) {
+ result = NT_STATUS_INTERNAL_ERROR;
+ goto done;
+ }
+
netsamlogon_cache_store(name_user, info3);
wcache_invalidate_samlogon(find_domain_from_name(name_domain), info3);