summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRichard Sharpe <realrichardsharpe@gmail.com>2012-05-16 20:21:34 -0700
committerRichard Sharpe <sharpe@samba.org>2012-05-17 07:17:29 +0200
commit632af6645376185500820a5be9dbf5c0c3d1e515 (patch)
tree77dfd7fe9c9615d76aa1fb1bba5496994d14d412
parent6bafb4ac25989fd5d637db0da4afab5ae36bad1c (diff)
downloadsamba-632af6645376185500820a5be9dbf5c0c3d1e515.tar.gz
samba-632af6645376185500820a5be9dbf5c0c3d1e515.tar.xz
samba-632af6645376185500820a5be9dbf5c0c3d1e515.zip
Check the return from create_acl_blob
Autobuild-User: Richard Sharpe <sharpe@samba.org> Autobuild-Date: Thu May 17 07:17:29 CEST 2012 on sn-devel-104
-rw-r--r--source3/modules/vfs_acl_common.c10
1 files changed, 6 insertions, 4 deletions
diff --git a/source3/modules/vfs_acl_common.c b/source3/modules/vfs_acl_common.c
index 221b43f7481..c7bce5710aa 100644
--- a/source3/modules/vfs_acl_common.c
+++ b/source3/modules/vfs_acl_common.c
@@ -592,10 +592,12 @@ static NTSTATUS fset_nt_acl_common(vfs_handle_struct *handle, files_struct *fsp,
NDR_PRINT_DEBUG(security_descriptor,
discard_const_p(struct security_descriptor, psd));
}
- /*
- * Perhaps create_acl_blob should have a status return as well
- */
- create_acl_blob(psd, &blob, XATTR_SD_HASH_TYPE_SHA256, hash);
+ status = create_acl_blob(psd, &blob, XATTR_SD_HASH_TYPE_SHA256, hash);
+ if (!NT_STATUS_IS_OK(status)) {
+ DEBUG(10, ("fset_nt_acl_xattr: create_acl_blob failed\n"));
+ return status;
+ }
+
status = store_acl_blob_fsp(handle, fsp, &blob);
return status;