diff options
| author | Jeremy Allison <jra@samba.org> | 2002-01-04 22:29:43 +0000 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2002-01-04 22:29:43 +0000 |
| commit | 5944a84eacb8542b417c27108a84f9b312f0e1f1 (patch) | |
| tree | 0563adce5902cc549d5dad9d0cbe470cab48ede4 | |
| parent | 8cc78b018a7935c1522925b2caff0f120b1a1a4a (diff) | |
| download | samba-5944a84eacb8542b417c27108a84f9b312f0e1f1.tar.gz samba-5944a84eacb8542b417c27108a84f9b312f0e1f1.tar.xz samba-5944a84eacb8542b417c27108a84f9b312f0e1f1.zip | |
Missed error return if can_rename fails.
Jeremy.
| -rw-r--r-- | source/smbd/reply.c | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/source/smbd/reply.c b/source/smbd/reply.c index 7c4b130fc3f..a9e227d0bc4 100644 --- a/source/smbd/reply.c +++ b/source/smbd/reply.c @@ -3659,13 +3659,13 @@ static BOOL resolve_wildcards(char *name1,char *name2) static NTSTATUS can_rename(char *fname,connection_struct *conn) { - if (!CAN_WRITE(conn)) - return NT_STATUS_ACCESS_DENIED; + if (!CAN_WRITE(conn)) + return NT_STATUS_ACCESS_DENIED; - if (!check_file_sharing(conn,fname,True)) - return NT_STATUS_SHARING_VIOLATION; + if (!check_file_sharing(conn,fname,True)) + return NT_STATUS_SHARING_VIOLATION; - return NT_STATUS_OK; + return NT_STATUS_OK; } /**************************************************************************** @@ -3824,6 +3824,7 @@ directory = %s, newname = %s, newname_last_component = %s, is_8_3 = %d\n", if (!NT_STATUS_IS_OK(error)) { DEBUG(3,("rename_internals: Error %s rename %s -> %s\n", get_nt_error_msg(error), directory,newname)); + return error; } pstrcpy(zdirectory, dos_to_unix(directory, False)); |