diff options
author | Jeremy Allison <jra@samba.org> | 2001-08-20 22:13:53 +0000 |
---|---|---|
committer | Jeremy Allison <jra@samba.org> | 2001-08-20 22:13:53 +0000 |
commit | 41066208ad8ca20d35a32bdf9ad934e11465c8f1 (patch) | |
tree | 4551971fcb53166730ea6c701f7db456b5a7ebc5 | |
parent | afece03d023b2905c27e147516b61487a7503028 (diff) | |
download | samba-41066208ad8ca20d35a32bdf9ad934e11465c8f1.tar.gz samba-41066208ad8ca20d35a32bdf9ad934e11465c8f1.tar.xz samba-41066208ad8ca20d35a32bdf9ad934e11465c8f1.zip |
Ensure we are very explicit about what we're comparing when
we're comparing structures (ie. don't just do a memcmp). I
don't think this will fix the fcntl spin issue, but it's a
"just in case" change.
Jeremy.
-rw-r--r-- | source/locking/locking.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/source/locking/locking.c b/source/locking/locking.c index 9b393ed6bac..ee3ce7c7d41 100644 --- a/source/locking/locking.c +++ b/source/locking/locking.c @@ -448,8 +448,8 @@ size_t del_share_mode(files_struct *fsp, share_mode_entry **ppse) from the record */ for (i=0;i<data->num_share_mode_entries;) { if (shares[i].pid == pid && - memcmp(&shares[i].time, - &fsp->open_time,sizeof(struct timeval)) == 0) { + shares[i].time.tv_sec == fsp->open_time.tv_sec && + shares[i].time.tv_usec == fsp->open_time.tv_usec ) { *ppse = memdup(&shares[i], sizeof(*shares)); data->num_share_mode_entries--; memmove(&shares[i], &shares[i+1], @@ -566,8 +566,8 @@ static BOOL mod_share_mode(files_struct *fsp, for (i=0;i<data->num_share_mode_entries;i++) { if (pid == shares[i].pid && shares[i].share_mode == fsp->share_mode && - memcmp(&shares[i].time, - &fsp->open_time,sizeof(struct timeval)) == 0) { + shares[i].time.tv_sec == fsp->open_time.tv_sec && + shares[i].time.tv_usec == fsp->open_time.tv_usec ) { mod_fn(&shares[i], fsp->dev, fsp->inode, param); need_store=1; } |