diff options
| author | Jeremy Allison <jra@samba.org> | 2002-11-19 01:46:10 +0000 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2002-11-19 01:46:10 +0000 |
| commit | 3bf21ca936973efcd74b826bc750131c6ab2c701 (patch) | |
| tree | 4b9e1e469caa7dadd39bfd46daef9efd38f470ad | |
| parent | ca689916da200f2d772b007a913665a6b7df5bd7 (diff) | |
| download | samba-3bf21ca936973efcd74b826bc750131c6ab2c701.tar.gz samba-3bf21ca936973efcd74b826bc750131c6ab2c701.tar.xz samba-3bf21ca936973efcd74b826bc750131c6ab2c701.zip | |
Very curious. It turns out attribute matching on truncate only matters
when opening truncate with current SYSTEM|HIDDEN -> NONE. It's fine to
truncate on open with current NONE -> SYSTEM | HIDDEN.
Jeremy.
| -rw-r--r-- | source/smbd/open.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/source/smbd/open.c b/source/smbd/open.c index 94a705e6b63..cee2b371849 100644 --- a/source/smbd/open.c +++ b/source/smbd/open.c @@ -712,11 +712,11 @@ static BOOL open_match_attributes(connection_struct *conn, char *path, mode_t ex /* If we're mapping SYSTEM and HIDDEN ensure they match. */ if (lp_map_system(SNUM(conn))) { - if ((old_dos_mode & FILE_ATTRIBUTE_SYSTEM) != (new_dos_mode & FILE_ATTRIBUTE_SYSTEM)) + if ((old_dos_mode & FILE_ATTRIBUTE_SYSTEM) && !(new_dos_mode & FILE_ATTRIBUTE_SYSTEM)) return False; } if (lp_map_hidden(SNUM(conn))) { - if ((old_dos_mode & FILE_ATTRIBUTE_HIDDEN) != (new_dos_mode & FILE_ATTRIBUTE_HIDDEN)) + if ((old_dos_mode & FILE_ATTRIBUTE_HIDDEN) && !(new_dos_mode & FILE_ATTRIBUTE_HIDDEN)) return False; } return True; |