diff options
| author | Martin Pool <mbp@samba.org> | 2003-02-13 04:46:55 +0000 |
|---|---|---|
| committer | Martin Pool <mbp@samba.org> | 2003-02-13 04:46:55 +0000 |
| commit | 2b5664823e05e328c86051fb607182ad20d786d4 (patch) | |
| tree | 749a1b75af8fc92294b20b35ef6b449aaab0843a | |
| parent | fe5582c1b2e1c6a6ed5e048dd169a1fcf908069c (diff) | |
| download | samba-2b5664823e05e328c86051fb607182ad20d786d4.tar.gz samba-2b5664823e05e328c86051fb607182ad20d786d4.tar.xz samba-2b5664823e05e328c86051fb607182ad20d786d4.zip | |
Add FIXME about checking exit code for popen'd commands.
Fix typo.
| -rw-r--r-- | source/lib/util_file.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/source/lib/util_file.c b/source/lib/util_file.c index 611e0e40be9..4babab89310 100644 --- a/source/lib/util_file.c +++ b/source/lib/util_file.c @@ -362,7 +362,7 @@ char *file_pload(char *syscmd, size_t *size) while ((n = read(fd, buf, sizeof(buf))) > 0) { tp = Realloc(p, total + n + 1); if (!tp) { - DEBUG(0,("file_pload: failed to exand buffer!\n")); + DEBUG(0,("file_pload: failed to expand buffer!\n")); close(fd); SAFE_FREE(p); return NULL; @@ -372,6 +372,9 @@ char *file_pload(char *syscmd, size_t *size) } if (p) p[total] = 0; + /* FIXME: Perhaps ought to check that the command completed + * successfully (returned 0); if not the data may be + * truncated. */ sys_pclose(fd); if (size) *size = total; |