diff options
| author | Jan Cholasta <jcholast@redhat.com> | 2016-05-30 09:40:07 +0200 |
|---|---|---|
| committer | Jan Cholasta <jcholast@redhat.com> | 2016-06-03 09:00:34 +0200 |
| commit | ed4c2d9252a995d01dc098e5b761ded8cd9373d8 (patch) | |
| tree | 67740ac3ee8133a7bd49ffef5ee216762b25cc89 /ipatests | |
| parent | fe18adb25839bf191aa748f13e75bfccb10f4a57 (diff) | |
| download | freeipa-ed4c2d9252a995d01dc098e5b761ded8cd9373d8.tar.gz freeipa-ed4c2d9252a995d01dc098e5b761ded8cd9373d8.tar.xz freeipa-ed4c2d9252a995d01dc098e5b761ded8cd9373d8.zip | |
plugable: turn Plugin attributes into properties
Implement the `name`, `doc` and `summary` Plugin attributes as properties
to allow them to be overriden in sub-classes.
Always use .doc rather than .__doc__ to access plugin documentation.
Remove the mostly unused `module`, `fullname`, `bases` and `label`
attributes.
https://fedorahosted.org/freeipa/ticket/4739
Reviewed-By: David Kupka <dkupka@redhat.com>
Diffstat (limited to 'ipatests')
| -rw-r--r-- | ipatests/test_cmdline/test_help.py | 2 | ||||
| -rw-r--r-- | ipatests/test_ipalib/test_plugable.py | 4 |
2 files changed, 1 insertions, 5 deletions
diff --git a/ipatests/test_cmdline/test_help.py b/ipatests/test_cmdline/test_help.py index 40b99c19c..7940086e7 100644 --- a/ipatests/test_cmdline/test_help.py +++ b/ipatests/test_cmdline/test_help.py @@ -114,7 +114,7 @@ def test_command_help(): assert h_ctx.stderr == '' assert h_ctx.stdout == help_ctx.stdout - assert unicode(user_add.__doc__) in help_ctx.stdout + assert unicode(user_add.doc) in help_ctx.stdout def test_ambiguous_command_or_topic(): diff --git a/ipatests/test_ipalib/test_plugable.py b/ipatests/test_ipalib/test_plugable.py index a618550e7..e8e867d85 100644 --- a/ipatests/test_ipalib/test_plugable.py +++ b/ipatests/test_ipalib/test_plugable.py @@ -52,8 +52,6 @@ class test_Plugin(ClassChecker): api = 'the api instance' o = self.cls(api) assert o.name == 'Plugin' - assert o.module == 'ipalib.plugable' - assert o.fullname == 'ipalib.plugable.Plugin' assert isinstance(o.doc, text.Gettext) class some_subclass(self.cls): """ @@ -67,8 +65,6 @@ class test_Plugin(ClassChecker): """ o = some_subclass(api) assert o.name == 'some_subclass' - assert o.module == __name__ - assert o.fullname == '%s.some_subclass' % __name__ assert o.summary == 'Do sub-classy things.' assert isinstance(o.doc, text.Gettext) class another_subclass(self.cls): |