diff options
| author | Stanislav Laznicka <slaznick@redhat.com> | 2016-02-02 12:50:26 +0100 |
|---|---|---|
| committer | Jan Cholasta <jcholast@redhat.com> | 2016-02-24 09:21:30 +0100 |
| commit | 9757384c7c6337138b6e096d3bb926cdb3012ff6 (patch) | |
| tree | 0e5404fa472a1904b7eeaebabfc5620fdce0d2fd /ipapython | |
| parent | 0accf8ccb64963954dbe7c137d23f52e5901ac4f (diff) | |
| download | freeipa-9757384c7c6337138b6e096d3bb926cdb3012ff6.tar.gz freeipa-9757384c7c6337138b6e096d3bb926cdb3012ff6.tar.xz freeipa-9757384c7c6337138b6e096d3bb926cdb3012ff6.zip | |
Cosmetic changes to the code
Fixes some Coverity issues
ipadiscovery.py: added assert should universe break
plugins/dns.py: removed dead code
dnssec/ldapkeydb.py: attribute assert in the proper object
test_automount_plugin.py: fixed possible close() on None
xmlrpc_test.py: Coverity does not like accessing None.__class__
https://fedorahosted.org/freeipa/ticket/5661
Reviewed-By: Jan Cholasta <jcholast@redhat.com>
Reviewed-By: Martin Basti <mbasti@redhat.com>
Diffstat (limited to 'ipapython')
| -rw-r--r-- | ipapython/dnssec/ldapkeydb.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ipapython/dnssec/ldapkeydb.py b/ipapython/dnssec/ldapkeydb.py index 55c09c040..aa0413934 100644 --- a/ipapython/dnssec/ldapkeydb.py +++ b/ipapython/dnssec/ldapkeydb.py @@ -288,7 +288,7 @@ class LdapKeyDB(AbstractHSM): for attr in default_attrs: key.setdefault(attr, default_attrs[attr]) - assert 'ipk11id' in o, 'key is missing ipk11Id in %s' % key.entry.dn + assert 'ipk11id' in key, 'key is missing ipk11Id in %s' % key.entry.dn key_id = key['ipk11id'] assert key_id not in keys, 'duplicate ipk11Id=0x%s in "%s" and "%s"' % (hexlify(key_id), key.entry.dn, keys[key_id].entry.dn) assert 'ipk11label' in key, 'key "%s" is missing ipk11Label' % key.entry.dn |