webui: fix regression: enabled gid field on group add

GID field should be enabled by default since the default group is posix.

Was caused by option_widget_base not properly reporting value change while
selecting the default value. It has to be notified with delay otherwise the
event is consumed by FieldBinder.

https://fedorahosted.org/freeipa/ticket/4325

Reviewed-By: Endi Sukma Dewata <edewata@redhat.com>

2 files changed, 6 insertions, 3 deletions

diff --git a/install/ui/src/freeipa/group.js b/install/ui/src/freeipa/group.js
index f2103f8e8..3961384dc 100644
--- a/install/ui/src/freeipa/group.js
+++ b/install/ui/src/freeipa/group.js
@@ -21,6 +21,7 @@
  */
 
 define([
+        'dojo/on',
         './ipa',
         './jquery',
         './phases',
@@ -29,7 +30,7 @@ define([
         './search',
         './association',
         './entity'],
-    function(IPA, $, phases, reg) {
+    function(on, IPA, $, phases, reg) {
 
 var exp = IPA.group = {};
 
@@ -197,14 +198,14 @@ IPA.group_adder_dialog = function(spec) {
     var init = function() {
 
         var type_field = that.fields.get_field('type');
-        type_field.widget.value_changed.attach(that.on_type_change);
+        on(type_field, 'value-change', that.on_type_change);
     };
 
     that.on_type_change = function() {
 
         var type_field = that.fields.get_field('type');
         var gid_field = that.fields.get_field('gidnumber');
-        var posix = type_field.save()[0] === 'posix';
+        var posix = type_field.get_value()[0] === 'posix';
 
         if (!posix) {
             gid_field.reset();
diff --git a/install/ui/src/freeipa/widget.js b/install/ui/src/freeipa/widget.js
index fc60959cd..0a9c491f3 100644
--- a/install/ui/src/freeipa/widget.js
+++ b/install/ui/src/freeipa/widget.js
@@ -1590,6 +1590,8 @@ IPA.option_widget_base = function(spec, that) {
                 // select default if none specified
                 if (that.default_value !== null) {
                     check(that._selector+'[value="'+that.default_value+'"]');
+                    // default was selected instead of supplied value, hence notify
+                    util.emit_delayed(that, 'value-change', { source: that });
                 } else {
                     // otherwise select empty
                     check(that._selector+'[value=""]');