Remove wildcard imports

Wildcard imports should not be used.

Check for wildcard imports has been enabled in pylint.
Pylint note: options 'wildcard-import' causes too much false positive
results, so instead it I used 'unused-wildcard-import' option which has almost
the same effect.

Reviewed-By: Jan Cholasta <jcholast@redhat.com>

9 files changed, 22 insertions, 10 deletions

diff --git a/install/tools/ipa-adtrust-install b/install/tools/ipa-adtrust-install
index b1197822c..8b3fce2db 100755
--- a/install/tools/ipa-adtrust-install
+++ b/install/tools/ipa-adtrust-install
@@ -23,17 +23,24 @@
 
 from __future__ import print_function
 
+import os
+import sys
+import ldap
+
 import six
 
 from ipaserver.install import adtrustinstance
-from ipaserver.install.installutils import *
+from ipaserver.install.installutils import (
+    read_password,
+    check_server_configuration,
+    run_script)
 from ipaserver.install import service
 from ipapython import version
 from ipapython import ipautil, sysrestore, ipaldap
 from ipalib import api, errors, krb_utils
 from ipapython.config import IPAOptionParser
 from ipaplatform.paths import paths
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger, standard_logging_setup
 from ipapython.dn import DN
 
 if six.PY3:
diff --git a/install/tools/ipa-ca-install b/install/tools/ipa-ca-install
index f2f32bd8e..f39847b90 100755
--- a/install/tools/ipa-ca-install
+++ b/install/tools/ipa-ca-install
@@ -35,7 +35,7 @@ from ipalib import api
 from ipalib.constants import DOMAIN_LEVEL_0
 from ipapython.dn import DN
 from ipapython.config import IPAOptionParser
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger, standard_logging_setup
 from ipaplatform.paths import paths
 
 log_file_name = paths.IPAREPLICA_CA_INSTALL_LOG
diff --git a/install/tools/ipa-compat-manage b/install/tools/ipa-compat-manage
index 1d0279b7d..29d1295f9 100755
--- a/install/tools/ipa-compat-manage
+++ b/install/tools/ipa-compat-manage
@@ -30,7 +30,7 @@ try:
     from ipaserver.install.ldapupdate import LDAPUpdate
     from ipaserver.plugins.ldap2 import ldap2
     from ipalib import api, errors
-    from ipapython.ipa_log_manager import *
+    from ipapython.ipa_log_manager import standard_logging_setup
     from ipapython.dn import DN
 except ImportError as e:
     print("""\
diff --git a/install/tools/ipa-csreplica-manage b/install/tools/ipa-csreplica-manage
index 5adfb799b..96f565839 100755
--- a/install/tools/ipa-csreplica-manage
+++ b/install/tools/ipa-csreplica-manage
@@ -25,7 +25,7 @@ from __future__ import print_function
 import sys
 import os
 
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger
 from ipaserver.install import (replication, installutils, bindinstance,
     cainstance, certs)
 from ipalib import api, errors
diff --git a/install/tools/ipa-dns-install b/install/tools/ipa-dns-install
index 720e08265..91f608941 100755
--- a/install/tools/ipa-dns-install
+++ b/install/tools/ipa-dns-install
@@ -21,14 +21,19 @@
 
 from __future__ import print_function
 
+import os
+import sys
+
 from optparse import SUPPRESS_HELP
 
 from ipaserver.install import bindinstance, httpinstance
-from ipaserver.install.installutils import *
 from ipaserver.install import installutils
+from ipaserver.install import service
 from ipapython import version
 from ipalib import api
 from ipaplatform.paths import paths
+from ipapython import ipautil
+from ipapython import sysrestore
 from ipapython.config import IPAOptionParser
 from ipapython.ipa_log_manager import standard_logging_setup, root_logger
 
diff --git a/install/tools/ipa-managed-entries b/install/tools/ipa-managed-entries
index 9b22d2c70..c786e883a 100755
--- a/install/tools/ipa-managed-entries
+++ b/install/tools/ipa-managed-entries
@@ -28,7 +28,7 @@ from ipapython import config, ipaldap
 from ipaserver.install import installutils
 from ipalib import api, errors
 from ipalib.constants import CACERT
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger, standard_logging_setup
 from ipapython.dn import DN
 
 def parse_options():
diff --git a/install/tools/ipa-nis-manage b/install/tools/ipa-nis-manage
index 6136f4436..3aa1507b2 100755
--- a/install/tools/ipa-nis-manage
+++ b/install/tools/ipa-nis-manage
@@ -31,7 +31,7 @@ try:
     from ipaserver.install.ldapupdate import LDAPUpdate
     from ipaserver.plugins.ldap2 import ldap2
     from ipalib import api, errors
-    from ipapython.ipa_log_manager import *
+    from ipapython.ipa_log_manager import standard_logging_setup
     from ipapython.dn import DN
     from ipaplatform import services
 except ImportError as e:
diff --git a/install/tools/ipa-replica-conncheck b/install/tools/ipa-replica-conncheck
index d36732351..52734c3c8 100755
--- a/install/tools/ipa-replica-conncheck
+++ b/install/tools/ipa-replica-conncheck
@@ -27,7 +27,7 @@ from ipalib import api, errors, x509
 from ipaserver.install import installutils
 import ipaclient.ipachangeconf
 from optparse import OptionGroup, OptionValueError
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger, standard_logging_setup
 import sys
 import os
 import signal
diff --git a/install/tools/ipa-replica-manage b/install/tools/ipa-replica-manage
index 654ea59a2..e4af7b2fd 100755
--- a/install/tools/ipa-replica-manage
+++ b/install/tools/ipa-replica-manage
@@ -38,7 +38,7 @@ from ipapython import version, ipaldap
 from ipalib import api, errors
 from ipalib.constants import CACERT
 from ipalib.util import has_managed_topology
-from ipapython.ipa_log_manager import *
+from ipapython.ipa_log_manager import root_logger, standard_logging_setup
 from ipapython.dn import DN
 from ipapython.config import IPAOptionParser
 from ipaclient import ipadiscovery