summaryrefslogtreecommitdiffstats
path: root/install/tools
diff options
context:
space:
mode:
authorMartin Basti <mbasti@redhat.com>2016-05-19 13:50:38 +0200
committerMartin Basti <mbasti@redhat.com>2016-05-31 14:08:54 +0200
commit5f42b42bd4557a669ab5cfcf1af6596f1a2535f1 (patch)
tree1e79933fb82d3166dd6a76be453b29728302a795 /install/tools
parent91572afc60f590f0d81ad18234189a0b48144bf5 (diff)
downloadfreeipa-5f42b42bd4557a669ab5cfcf1af6596f1a2535f1.tar.gz
freeipa-5f42b42bd4557a669ab5cfcf1af6596f1a2535f1.tar.xz
freeipa-5f42b42bd4557a669ab5cfcf1af6596f1a2535f1.zip
Performance: Find commands: do not process members by default
In all *-find commands, member attributes shouldn't be processed due high amount fo ldpaserches cause serious performance issues. For this reason --no-members option is set by default in CLI and API. To get members in *-find command option --all in CLI is rquired or 'no_members=False' or 'all=True' must be set in API call. For other commands processing of members stays unchanged. WebUI is not affected by this change. https://fedorahosted.org/freeipa/ticket/4995 Reviewed-By: Martin Babinsky <mbabinsk@redhat.com>
Diffstat (limited to 'install/tools')
-rwxr-xr-xinstall/tools/ipa-replica-manage6
1 files changed, 4 insertions, 2 deletions
diff --git a/install/tools/ipa-replica-manage b/install/tools/ipa-replica-manage
index 8e692d295..9f6cfa6ca 100755
--- a/install/tools/ipa-replica-manage
+++ b/install/tools/ipa-replica-manage
@@ -945,7 +945,8 @@ def del_master_managed(realm, hostname, options):
sys.exit(1)
# 2. Get all masters
- masters = api.Command.server_find('', sizelimit=0)['result']
+ masters = api.Command.server_find(
+ '', sizelimit=0, no_members=False)['result']
# 3. Check topology connectivity in all suffixes
topo_errors = replication.check_last_link_managed(api, hostname, masters)
@@ -1149,7 +1150,8 @@ def del_master_direct(realm, hostname, options):
# Check for orphans if the remote server is up.
if delrepl and not winsync:
try:
- masters = api.Command.server_find('', sizelimit=0)['result']
+ masters = api.Command.server_find(
+ '', sizelimit=0, no_members=False)['result']
except Exception as e:
masters = []
print("Failed to read masters data from '%s': %s" % (