diff options
author | Martin Basti <mbasti@redhat.com> | 2015-12-17 00:17:09 +0100 |
---|---|---|
committer | Jan Cholasta <jcholast@redhat.com> | 2015-12-23 07:59:22 +0100 |
commit | 9f4924647675e19ab2878bcc917a35fe7ffe7e7e (patch) | |
tree | 7989ad1039f895f835fc5d8c2cbf4a663eb7c756 | |
parent | 81ff72b9af04a009689282a5160c0b5a9d5421c1 (diff) | |
download | freeipa-9f4924647675e19ab2878bcc917a35fe7ffe7e7e.tar.gz freeipa-9f4924647675e19ab2878bcc917a35fe7ffe7e7e.tar.xz freeipa-9f4924647675e19ab2878bcc917a35fe7ffe7e7e.zip |
Enable pylint unused-format-string-key check
Enables check and fixes:
ipatests/test_xmlrpc/test_permission_plugin.py:534:
[W1301(unused-format-string-key), test_permission] Unused key 'tdn' in
format string dictionary)
ipatests/test_xmlrpc/test_permission_plugin.py:652:
[W1301(unused-format-string-key), test_permission] Unused key 'tdn' in
format string dictionary)
Reviewed-By: Jan Cholasta <jcholast@redhat.com>
-rw-r--r-- | ipatests/test_xmlrpc/test_permission_plugin.py | 6 | ||||
-rwxr-xr-x | make-lint | 1 |
2 files changed, 2 insertions, 5 deletions
diff --git a/ipatests/test_xmlrpc/test_permission_plugin.py b/ipatests/test_xmlrpc/test_permission_plugin.py index 517b8205e..012946658 100644 --- a/ipatests/test_xmlrpc/test_permission_plugin.py +++ b/ipatests/test_xmlrpc/test_permission_plugin.py @@ -533,8 +533,7 @@ class test_permission(Declarative): '(targetfilter = "(objectclass=posixaccount)")' + '(version 3.0;acl "permission:%(name)s";' 'allow (write) groupdn = "ldap:///%(pdn)s";)' % - {'tdn': DN(('uid', '*'), users_dn), - 'name': permission1, + {'name': permission1, 'pdn': permission1_dn}], }, ), @@ -651,8 +650,7 @@ class test_permission(Declarative): '(targetfilter = "(objectclass=posixaccount)")' + '(version 3.0;acl "permission:%(name)s";' 'allow (write) groupdn = "ldap:///%(pdn)s";)' % - {'tdn': DN(('uid', '*'), users_dn), - 'name': permission1, + {'name': permission1, 'pdn': permission1_dn}], }, ], @@ -279,7 +279,6 @@ def main(): linter.set_option('disable', 'unnecessary-pass') linter.set_option('disable', 'unnecessary-semicolon') linter.set_option('disable', 'unused-argument') - linter.set_option('disable', 'unused-format-string-key') linter.set_option('disable', 'unused-variable') linter.set_option('disable', 'useless-else-on-loop') linter.set_option('disable', 'unbalanced-tuple-unpacking') |