diff options
| author | Rich Megginson <rmeggins@redhat.com> | 2009-05-19 13:17:11 -0600 |
|---|---|---|
| committer | Rich Megginson <rmeggins@redhat.com> | 2009-05-19 14:05:25 -0600 |
| commit | f9db3ac14855eb07e49f2f5797cbb7d338bb614b (patch) | |
| tree | 4bc8d8283ba975ed2decaa664615548081866679 /ldap/servers/slapd/snmp_collator.c | |
| parent | 47a59378cbf4b48eef492530ebc1c8ea6059a757 (diff) | |
| download | ds-f9db3ac14855eb07e49f2f5797cbb7d338bb614b.tar.gz ds-f9db3ac14855eb07e49f2f5797cbb7d338bb614b.tar.xz ds-f9db3ac14855eb07e49f2f5797cbb7d338bb614b.zip | |
Fix various compiler warnings
1) Make sure we use "const" consistently
2) Make sure we use "unsigned char" consistently
for some reason (unsigned char)*p did not compare to '\xHH' literals unless the literal was also cast to (unsigned char)
3) added some missing function prototypes
4) removed some unused variables/functions, or commented out for use when debugging
5) various other compiler warnings
With all of these, the code compiles cleanly on RHEL5 x86_64 using
gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-44)
and
CFLAGS="-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic"
The only warning now is the spurious message about %llu or %lld having the wrong format argument.
Reviewed by: nhosoi (Thanks!)
Diffstat (limited to 'ldap/servers/slapd/snmp_collator.c')
| -rw-r--r-- | ldap/servers/slapd/snmp_collator.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/ldap/servers/slapd/snmp_collator.c b/ldap/servers/slapd/snmp_collator.c index 9fb629d2..9beb878a 100644 --- a/ldap/servers/slapd/snmp_collator.c +++ b/ldap/servers/slapd/snmp_collator.c @@ -80,7 +80,9 @@ #define URL_CHARS_LEN 9 static char *make_ds_url(char *host, int port); +#ifdef DEBUG_SNMP_INTERACTION static void print_snmp_interaction_table(); +#endif /* DEBUG_SNMP_INTERACTION */ static int search_interaction_table(char *dsURL, int *isnew); static void loadConfigStats(); static Slapi_Entry *getConfigEntry( Slapi_Entry **e ); @@ -338,6 +340,8 @@ static int search_interaction_table(char *dsURL, int *isnew) return index; } + +#ifdef DEBUG_SNMP_INTERACTION /* for debuging until subagent part working, print contents of interaction table */ static void print_snmp_interaction_table() { @@ -356,6 +360,7 @@ static void print_snmp_interaction_table() fprintf(stderr, "\n"); } } +#endif /* DEBUG_SNMP_INTERACTION */ /*------------------------------------------------------------------------- * |