diff options
| author | Rich Megginson <rmeggins@redhat.com> | 2009-05-19 13:17:11 -0600 |
|---|---|---|
| committer | Rich Megginson <rmeggins@redhat.com> | 2009-05-19 14:05:25 -0600 |
| commit | f9db3ac14855eb07e49f2f5797cbb7d338bb614b (patch) | |
| tree | 4bc8d8283ba975ed2decaa664615548081866679 /ldap/servers/slapd/pblock.c | |
| parent | 47a59378cbf4b48eef492530ebc1c8ea6059a757 (diff) | |
| download | ds-f9db3ac14855eb07e49f2f5797cbb7d338bb614b.tar.gz ds-f9db3ac14855eb07e49f2f5797cbb7d338bb614b.tar.xz ds-f9db3ac14855eb07e49f2f5797cbb7d338bb614b.zip | |
Fix various compiler warnings
1) Make sure we use "const" consistently
2) Make sure we use "unsigned char" consistently
for some reason (unsigned char)*p did not compare to '\xHH' literals unless the literal was also cast to (unsigned char)
3) added some missing function prototypes
4) removed some unused variables/functions, or commented out for use when debugging
5) various other compiler warnings
With all of these, the code compiles cleanly on RHEL5 x86_64 using
gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-44)
and
CFLAGS="-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic"
The only warning now is the spurious message about %llu or %lld having the wrong format argument.
Reviewed by: nhosoi (Thanks!)
Diffstat (limited to 'ldap/servers/slapd/pblock.c')
| -rw-r--r-- | ldap/servers/slapd/pblock.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ldap/servers/slapd/pblock.c b/ldap/servers/slapd/pblock.c index dd8239db..c89a6485 100644 --- a/ldap/servers/slapd/pblock.c +++ b/ldap/servers/slapd/pblock.c @@ -1082,7 +1082,7 @@ slapi_pblock_get( Slapi_PBlock *pblock, int arg, void *value ) if ( pblock->pb_plugin->plg_type != SLAPI_PLUGIN_SYNTAX ) { return( -1 ); } - (*(int *)value) = pblock->pb_plugin->plg_syntax_validate; + (*(IFP *)value) = pblock->pb_plugin->plg_syntax_validate; break; /* controls we know about */ |