diff options
| author | Rich Megginson <rmeggins@redhat.com> | 2007-10-18 22:25:14 +0000 |
|---|---|---|
| committer | Rich Megginson <rmeggins@redhat.com> | 2007-10-18 22:25:14 +0000 |
| commit | d81e2fa8e34a5b8d0ceb9d35e106ba1b1cc66496 (patch) | |
| tree | 5224ff818b185420e4fa6bc655e4684ba011adbb /ldap/servers/slapd/index_subsystem.c | |
| parent | 0679cf419684a327572289ee381411ea4db92166 (diff) | |
| download | ds-d81e2fa8e34a5b8d0ceb9d35e106ba1b1cc66496.tar.gz ds-d81e2fa8e34a5b8d0ceb9d35e106ba1b1cc66496.tar.xz ds-d81e2fa8e34a5b8d0ceb9d35e106ba1b1cc66496.zip | |
Resolves: bug 297221
Bug Description: rhds71 Malformed Dynamic Authorization Group makes Directory Server Crash
Reviewed by: nhosoi (Thanks!)
Fix Description: The problem was that we were not checking the return value of slapi_str2filter(). I added a check at the crash site, and it will not print out a helpful error message. I did a search through the code looking for other similar places and found a couple. I added similar code in those places.
I added an initialization of a buffer to null, as suggested by nhosoi.
Platforms tested: RHEL5 x86_64
Flag Day: no
Doc impact: no
Diffstat (limited to 'ldap/servers/slapd/index_subsystem.c')
| -rw-r--r-- | ldap/servers/slapd/index_subsystem.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ldap/servers/slapd/index_subsystem.c b/ldap/servers/slapd/index_subsystem.c index a1e05156..a0b16b0f 100644 --- a/ldap/servers/slapd/index_subsystem.c +++ b/ldap/servers/slapd/index_subsystem.c @@ -1030,7 +1030,7 @@ int slapi_index_register_index(char *plugin_id, indexed_item *registration_item, Slapi_Filter *tmp_f = slapi_str2filter(registration_item->index_filter); Slapi_Backend *be; - if(!theCache) + if(!theCache || !tmp_f) return -1; index_subsys_write_lock(); |