diff options
| author | Endi S. Dewata <edewata@redhat.com> | 2010-07-12 23:18:20 -0500 |
|---|---|---|
| committer | Noriko Hosoi <nhosoi@redhat.com> | 2010-08-19 13:02:13 -0700 |
| commit | 3abf9cf2d29d533ac10ed42fc4cd318b429e59ea (patch) | |
| tree | 835305be755fc704cb779f833a8737ecd229c1d3 /ldap/servers/slapd/dn.c | |
| parent | a05f87bef351fc87d32e0a9adc0aa7851bdb3200 (diff) | |
| download | ds-3abf9cf2d29d533ac10ed42fc4cd318b429e59ea.tar.gz ds-3abf9cf2d29d533ac10ed42fc4cd318b429e59ea.tar.xz ds-3abf9cf2d29d533ac10ed42fc4cd318b429e59ea.zip | |
Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
https://bugzilla.redhat.com/show_bug.cgi?id=614511
Resolves: bug 614511
Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891
description: Catch possible NULL pointer in slapi_dn_normalize_ext() and slapi_sdn_done().
Diffstat (limited to 'ldap/servers/slapd/dn.c')
| -rw-r--r-- | ldap/servers/slapd/dn.c | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/ldap/servers/slapd/dn.c b/ldap/servers/slapd/dn.c index e50ec768..d067d8c3 100644 --- a/ldap/servers/slapd/dn.c +++ b/ldap/servers/slapd/dn.c @@ -954,10 +954,12 @@ slapi_dn_normalize_ext(char *src, size_t src_len, char **dest, size_t *dest_len) *dest_len = d - *dest; bail: if (rc < 0) { - if (*dest != src) { - slapi_ch_free_string(dest); - } else { - *dest = NULL; + if (dest != NULL) { + if (*dest != src) { + slapi_ch_free_string(dest); + } else { + *dest = NULL; + } } *dest_len = 0; } else if (rc > 0) { @@ -1873,6 +1875,10 @@ void slapi_sdn_done(Slapi_DN *sdn) { /* sdn_dump( sdn, "slapi_sdn_done"); */ + if(sdn==NULL) + { + return; + } if(sdn->dn!=NULL) { if(slapi_isbitset_uchar(sdn->flag,FLAG_DN)) |