summaryrefslogtreecommitdiffstats
path: root/ldap/servers/slapd/csngen.h
diff options
context:
space:
mode:
authorRich Megginson <rmeggins@redhat.com>2008-08-27 21:05:49 +0000
committerRich Megginson <rmeggins@redhat.com>2008-08-27 21:05:49 +0000
commit41b1a8ff9d38c1c2e76461ac7da3721260419fdf (patch)
tree196d5a3f6de19e79a5f8305891b1885b5cc372d8 /ldap/servers/slapd/csngen.h
parentb621e8594f18242a6f9b45a4203b4a84a9c9829a (diff)
downloadds-41b1a8ff9d38c1c2e76461ac7da3721260419fdf.tar.gz
ds-41b1a8ff9d38c1c2e76461ac7da3721260419fdf.tar.xz
ds-41b1a8ff9d38c1c2e76461ac7da3721260419fdf.zip
Resolves: bug 458666
Bug Description: Memory leaks in check_trivial_words, check_pw_storagescheme_value Reviewed by: nkinder, nhosoi (Thanks!) Branch: HEAD Fix Description: The first leak happens when password policy is active and trivial words checking is being used, and the password is being modified. When getting the list of attribute from the existing entry in the modify case, the function slapi_attr_get_valueset is used - this function makes a duplicate of the valueset and overwrites the valueset argument. The fix is to move the allocation of vs until after the call to slapi_attr_get_valueset, and only allocate it if it is non NULL. The second leak happens when the password storage scheme is changed. The function check_pw_storagescheme_value uses pw_name2scheme to check the given scheme - this function allocates a struct pw_scheme * which must be freed with free_pw_scheme. Platforms tested: RHEL5, Fedora 8 Flag Day: no Doc impact: no QA impact: already covered by acceptance tests New Tests integrated into TET: none
Diffstat (limited to 'ldap/servers/slapd/csngen.h')
0 files changed, 0 insertions, 0 deletions