diff options
| author | Noriko Hosoi <nhosoi@redhat.com> | 2010-07-07 17:51:43 -0700 |
|---|---|---|
| committer | Noriko Hosoi <nhosoi@redhat.com> | 2010-07-23 13:39:38 -0700 |
| commit | 270fa7377ec1a49cf925381e1fe6b40759ec4d4e (patch) | |
| tree | 19452debed07297b7a6e116bd1276826c6ca5636 /ldap/servers/slapd/back-ldbm/misc.c | |
| parent | a24a746c029aea8c6cd66b7b6f1bf8ab5fea09ed (diff) | |
| download | ds-270fa7377ec1a49cf925381e1fe6b40759ec4d4e.tar.gz ds-270fa7377ec1a49cf925381e1fe6b40759ec4d4e.tar.xz ds-270fa7377ec1a49cf925381e1fe6b40759ec4d4e.zip | |
610281 - fix coverity Defect Type: Control flow issues
https://bugzilla.redhat.com/show_bug.cgi?id=610281
11821 DEADCODE Triaged Unassigned Bug Minor Fix Required
allinstance_set_busy() ds/ldap/servers/slapd/back-ldbm/misc.c
11822 DEADCODE Triaged Unassigned Bug Minor Fix Required
allinstance_set_not_busy() ds/ldap/servers/slapd/back-ldbm/misc.c
Comment:
objset_next_obj releases the previous object internally.
Thus, there is no leak. Just remove the 2 lines:
if (inst_obj)
object_release(inst_obj);
Diffstat (limited to 'ldap/servers/slapd/back-ldbm/misc.c')
| -rw-r--r-- | ldap/servers/slapd/back-ldbm/misc.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/ldap/servers/slapd/back-ldbm/misc.c b/ldap/servers/slapd/back-ldbm/misc.c index 2bcdd9d9..0e1dc60c 100644 --- a/ldap/servers/slapd/back-ldbm/misc.c +++ b/ldap/servers/slapd/back-ldbm/misc.c @@ -231,8 +231,6 @@ allinstance_set_not_busy(struct ldbminfo *li) inst = (ldbm_instance *)object_get_data(inst_obj); instance_set_not_busy(inst); } - if (inst_obj) - object_release(inst_obj); } void @@ -250,8 +248,6 @@ allinstance_set_busy(struct ldbminfo *li) inst->inst_name); } } - if (inst_obj) - object_release(inst_obj); } int |