Fix attrcrypt usage of nsSymmetricKey

The current attrcrypt is failing because it attempts to store the encryption
symkey in the nsSymmetricKey attribute.  This attribute is not defined in the
schema, so it defaults to DirectoryString syntax.  Storing the value then fails
syntax validation because the binary values in the key do not conform to
DirectoryString.  The code was poorly designed to handle and report errors of
this nature.  The real fix is to add nsSymmetricKey as a BINARY syntax
attribute.  I also cleaned up the error detection and reporting for this case.
Reviewed by: nkinder (Thanks!)

1 files changed, 6 insertions, 1 deletions

diff --git a/ldap/servers/slapd/back-ldbm/dblayer.c b/ldap/servers/slapd/back-ldbm/dblayer.c
index 4eeb93c1..42642b24 100644
--- a/ldap/servers/slapd/back-ldbm/dblayer.c
+++ b/ldap/servers/slapd/back-ldbm/dblayer.c
@@ -1837,7 +1837,12 @@ int dblayer_instance_start(backend *be, int mode)
         return 0;
     }
 
-    attrcrypt_init(inst);
+    if (attrcrypt_init(inst)) {
+        LDAPDebug(LDAP_DEBUG_ANY,
+                  "Error: unable to initialize attrcrypt system for %s\n",
+                  inst->inst_name, 0, 0);
+        return -1;
+    }
 
     /* Get the name of the directory that holds index files
      * for this instance. */