diff options
| author | Noriko Hosoi <nhosoi@redhat.com> | 2010-08-10 15:42:35 -0700 |
|---|---|---|
| committer | Noriko Hosoi <nhosoi@redhat.com> | 2010-08-11 15:51:59 -0700 |
| commit | 9a6187a33ab034a87239672332e685e25bada374 (patch) | |
| tree | 4731507aa2f03c1f3a6e2e4919a5d9ea9e3c8625 /ldap/servers/plugins/replication/windows_inc_protocol.c | |
| parent | e5e1227cb991b51b430d777e4c58b6a6add86a7c (diff) | |
| download | ds-9a6187a33ab034a87239672332e685e25bada374.tar.gz ds-9a6187a33ab034a87239672332e685e25bada374.tar.xz ds-9a6187a33ab034a87239672332e685e25bada374.zip | |
Bug 622903 - fix coverity Defect Type: Code maintainability issues
https://bugzilla.redhat.com/show_bug.cgi?id=622903
Comment:
Pointer "replica" returned by "object_get_data(prp->replica_object)"
(line 502) is never used. In "case STATE_READY_TO_ACQUIRE", Replica
object "replica" is not needed.
Diffstat (limited to 'ldap/servers/plugins/replication/windows_inc_protocol.c')
| -rw-r--r-- | ldap/servers/plugins/replication/windows_inc_protocol.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/ldap/servers/plugins/replication/windows_inc_protocol.c b/ldap/servers/plugins/replication/windows_inc_protocol.c index f2e9034d..e5e67c3b 100644 --- a/ldap/servers/plugins/replication/windows_inc_protocol.c +++ b/ldap/servers/plugins/replication/windows_inc_protocol.c @@ -499,7 +499,6 @@ windows_inc_run(Private_Repl_Protocol *prp) /* ONREPL - at this state we unconditionally acquire the replica ignoring all events. Not sure if this is good */ object_acquire(prp->replica_object); - replica = object_get_data(prp->replica_object); rc = windows_acquire_replica(prp, &ruv , (run_dirsync == 0) /* yes, check the consumer RUV for incremental, but not if we're going to dirsync afterwards */); @@ -539,7 +538,7 @@ windows_inc_run(Private_Repl_Protocol *prp) prp->last_acquire_response_code, NULL); } - object_release(prp->replica_object); replica = NULL; + object_release(prp->replica_object); break; case STATE_BACKOFF_START: |