diff options
| author | Rich Megginson <rmeggins@redhat.com> | 2010-10-01 16:38:04 -0600 |
|---|---|---|
| committer | Rich Megginson <rmeggins@redhat.com> | 2010-10-01 17:01:57 -0600 |
| commit | 4f410d762b008da8e2e43e29100c2c04ff332fbb (patch) | |
| tree | 6723ef832b034bda64cc691d252b42e522718bfa /ldap/servers/plugins/replication/repl_controls.c | |
| parent | a82f61269d69882d19b15def70de68906ed5740e (diff) | |
| download | ds-4f410d762b008da8e2e43e29100c2c04ff332fbb.tar.gz ds-4f410d762b008da8e2e43e29100c2c04ff332fbb.tar.xz ds-4f410d762b008da8e2e43e29100c2c04ff332fbb.zip | |
openldap ber_init will assert if the bv->bv_val is NULL
Have to ensure that all usage of ber_init in the server checks to see if
the bv->bv_val is non-NULL before using ber_init, and return the appropriate
error if it is NULL
Also fixed a problem in dna_extend_exop - would not send the ldap result to
the client in certain error conditions
Reviewed by: nhosoi (Thanks!)
Tested on: RHEL5 x86_64
Diffstat (limited to 'ldap/servers/plugins/replication/repl_controls.c')
| -rw-r--r-- | ldap/servers/plugins/replication/repl_controls.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/ldap/servers/plugins/replication/repl_controls.c b/ldap/servers/plugins/replication/repl_controls.c index cfd980fd..980bdd89 100644 --- a/ldap/servers/plugins/replication/repl_controls.c +++ b/ldap/servers/plugins/replication/repl_controls.c @@ -216,7 +216,7 @@ decode_NSDS50ReplUpdateInfoControl(LDAPControl **controlsp, if (slapi_control_present(controlsp, REPL_NSDS50_UPDATE_INFO_CONTROL_OID, &ctl_value, &iscritical)) { - if ((tmp_bere = ber_init(ctl_value)) == NULL) + if ((ctl_value->bv_val == NULL) || (tmp_bere = ber_init(ctl_value)) == NULL) { rc = -1; goto loser; |